Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] httpjson update docs #30739

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

leehinman
Copy link
Contributor

What does this PR do?

Updates documentation for accessing last_response.url.params in httpjson input.

Why is it important?

Previous documentation had params as a map which wasn't correct and lead to confusion about accessing the values in the params.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Screenshots

Screen Shot 2022-03-08 at 11 52 13

@leehinman leehinman added docs Team:Security-External Integrations backport-v8.1.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify labels Mar 8, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 8, 2022
@leehinman leehinman force-pushed the httpjson_params_doc_update branch from 988591d to d57ac6e Compare March 8, 2022 20:38
@leehinman leehinman marked this pull request as ready for review March 8, 2022 20:38
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 8, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview [preview](https://ci-stats.elastic.co/app/apm/services/beats-ci/transactions/view?rangeFrom=2022-03-10T15:48:14.027Z&rangeTo=2022-03-10T16:08:14.027Z&transactionName=BUILD Beats/beats/PR-{number}&transactionType=job&latencyAggregationType=avg&traceId=4198b7a52b1297737f2cc90b49cca584&transactionId=b0b788a273a61300)

Expand to view the summary

Build stats

  • Start Time: 2022-03-10T15:58:14.027+0000

  • Duration: 20 min 39 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh requested a review from marc-gr March 8, 2022 21:15
@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b httpjson_params_doc_update upstream/httpjson_params_doc_update
git merge upstream/main
git push upstream httpjson_params_doc_update

- update documentation for accessing last_response.url.params
  in httpjson input.
@leehinman leehinman force-pushed the httpjson_params_doc_update branch from d57ac6e to 73f0720 Compare March 10, 2022 15:57
@leehinman leehinman merged commit 8a60ca9 into elastic:main Mar 10, 2022
@leehinman leehinman deleted the httpjson_params_doc_update branch March 10, 2022 17:36
mergify bot pushed a commit that referenced this pull request Mar 10, 2022
- update documentation for accessing last_response.url.params
  in httpjson input.

(cherry picked from commit 8a60ca9)
mergify bot pushed a commit that referenced this pull request Mar 10, 2022
- update documentation for accessing last_response.url.params
  in httpjson input.

(cherry picked from commit 8a60ca9)
leehinman added a commit that referenced this pull request Mar 10, 2022
* [Filebeat] httpjson update docs (#30739)

- update documentation for accessing last_response.url.params
  in httpjson input.

(cherry picked from commit 8a60ca9)

Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com>
leehinman added a commit that referenced this pull request Mar 10, 2022
* [Filebeat] httpjson update docs (#30739)

- update documentation for accessing last_response.url.params
  in httpjson input.

(cherry picked from commit 8a60ca9)

Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.1.0 Automated backport with mergify docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants