[Oracle Module] Handle special characters for Oracle connection string properly

[yug-rajani]

• Enhancement

What does this PR do?

This PR enhances the Oracle Metricbeat Module to handle the special characters in the connection string properly.

Why is it important?

Many of the passwords are machine generated and often contain % at the very least, the workaround in the existing module was to not use these characters.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
  - [ ] I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

• Relates [Metricbeat : SQL & Oracle Modules] Connection string for Oracle does not handle special characters properly #24609

[elasticmachine]

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b oracle_special_characters upstream/oracle_special_characters
git merge upstream/main
git push upstream oracle_special_characters

[yug-rajani]

/test

[kush-elastic]

/test

[yug-rajani]

/test

[yug-rajani]

/test

[agithomas]

LGTM

[mdelapenya]

@yug-elastic I'm adding a 👍 in terms of the e2e tests as, for this PR, they have suffered a glitch in the parallel stages that they run. Because the vast majority of the tests are passing, and after a deeper investigation on the existing failures, I'd say that they are temporary and not related to this PR

[yug-rajani]

/test

[yug-rajani]

@yug-elastic I'm adding a 👍 in terms of the e2e tests as, for this PR, they have suffered a glitch in the parallel stages that they run. Because the vast majority of the tests are passing, and after a deeper investigation on the existing failures, I'd say that they are temporary and not related to this PR

Thank you for the approval, @mdelapenya! I wonder if it would be possible to merge this PR until we have a green checkmark over beats-ci/pr-merge check. If it's possible, kindly help us with it as we don't have the authority to merge this PR.

FYI, we have an approval from @agithomas who is the code owner of this change.

[yug-rajani]

/test

[yug-rajani]

/test

[yug-rajani]

/test

[yug-rajani]

/test

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b oracle_special_characters upstream/oracle_special_characters
git merge upstream/main
git push upstream oracle_special_characters

[cmacknz]

The E2E tests here are being triggered because of the updates to go.mod. There's nothing there that looks like it should be causing test failures, and I've seen the same set of tests failing on other branches recently, like https://beats-ci.elastic.co/job/e2e-tests/job/e2e-testing-mbp/job/main/1256/ for one example.

I'm going to merge this.

[yug-rajani]

Thanks a lot, @cmacknz!