Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat][Salesforce] Add Salesforce filebeat module #31486

Merged
merged 8 commits into from
May 23, 2022
Merged

[Filebeat][Salesforce] Add Salesforce filebeat module #31486

merged 8 commits into from
May 23, 2022

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented May 2, 2022 •
edited by yug-rajani
Loading

  • Enhancement

What does this PR do?

This PR contains event parsing, ECS Field Mappings and ingest pipelines for the filesets Login and Logout as a part of Salesforce Filebeat module.
The fields from Salesforce REST API and the Salesforce Streaming API have been taken into consideration.

Why is it important?

  • It is a prerequisite for the collection and parsing of the Login and Logout event data for the Salesforce Observability Connector.

Checklist

  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related

@kush-elastic kush-elastic requested review from a team as code owners May 2, 2022 19:37
@kush-elastic kush-elastic requested review from belimawr and leehinman and removed request for a team May 2, 2022 19:37
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 2, 2022
@kush-elastic kush-elastic changed the title initial commit for salesforce filebeat module [Filebeat][Salesforce] Add Salesforce filebeat module May 2, 2022
@kush-elastic kush-elastic self-assigned this May 2, 2022
@kush-elastic kush-elastic added Filebeat Filebeat Team:Service-Integrations Label for the Service Integrations team Module:beat The beat Metricbeat module labels May 2, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 2, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 2, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-09T18:12:53.962+0000

  • Duration: 76 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 6246
Skipped 728
Total 6974

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kush-elastic kush-elastic requested a review from mtojek May 6, 2022 12:39
@mtojek mtojek requested a review from a team May 6, 2022 13:45
mtojek
mtojek approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test files LGTM. Thanks for adding them. Let's wait for other approvals.

@ishleenk17 ishleenk17 merged commit ae7be61 into elastic:main May 23, 2022
@kush-elastic kush-elastic mentioned this pull request Jun 1, 2022
Merged
2 tasks
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@kush-elastic @yug-rajani @chrisberkhout
[Filebeat][Salesforce] Add Salesforce filebeat module (#31486)
c0fcf0d 
* initial commit for salesforce filebeat module

* Update dashboards

* Add CHANGELOG.next.asciidoc entry

* Update docs

* fix for .var not found error in pythonIntegTest

* Complete integrtion tests

* Resolve make update

Co-authored-by: yug-elastic <96041884+yug-elastic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

@ishleenk17 ishleenk17 ishleenk17 approved these changes

Assignees

@kush-elastic kush-elastic

Labels
Filebeat Filebeat Module:beat The beat Metricbeat module Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kush-elastic @elasticmachine @mtojek @ishleenk17 @yug-rajani