-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ambiguity on Dockerfile CMD. #31500
Conversation
💚 CLA has been signed |
❕ Build Aborted
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
|
f6c4f14
to
ac43333
Compare
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @mighty1231! I added only a small comment.
ac43333
to
a81845a
Compare
/test |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This pull request is now in conflicts. Could you fix it? 🙏
|
a81845a
to
e5b2cd2
Compare
this E2E tests seem to be stuck :/ |
/test |
@mergify help |
Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
I think those E2E tests are not in this branch yet, I'll ask mergify to rebase this PR onto main. |
@Mergifyio rebase |
✅ Branch has been successfully rebased |
e5b2cd2
to
d02a5cb
Compare
/test |
2 similar comments
/test |
/test |
@Mergifyio rebase |
✅ Branch has been successfully rebased |
d02a5cb
to
36f60ff
Compare
/test |
@Mergifyio rebase |
✅ Branch has been successfully rebased |
This pull request is now in conflicts. Could you fix it? 🙏
|
1 similar comment
This pull request is now in conflicts. Could you fix it? 🙏
|
❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
Closing. Re-open when ready for re-review. |
What does this PR do?
Beat binaries have two options,
-e
and--environment
have different use.This MR reveals new Dockerfile, use of
--environment
instead-environment
, and some change on document.Why is it important?
Use of
-environment
increases ambiguity, since beats have-e
options, which sends logs for stderr.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Additional Checklist
environment
flag usage in entire repository with single minus characterRelated issues
-environment
to--environment