Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ambiguity on Dockerfile CMD. #31500

Closed
wants to merge 3 commits into from

Conversation

mighty1231
Copy link

@mighty1231 mighty1231 commented May 3, 2022

What does this PR do?

Beat binaries have two options, -e and --environment have different use.

This MR reveals new Dockerfile, use of --environment instead -environment, and some change on document.

Why is it important?

Use of -environment increases ambiguity, since beats have -e options, which sends logs for stderr.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Additional Checklist

  • Checked any environment flag usage in entire repository with single minus character

Related issues

@mighty1231 mighty1231 requested a review from a team as a code owner May 3, 2022 15:47
@mighty1231 mighty1231 requested review from belimawr and kvch and removed request for a team May 3, 2022 15:47
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 3, 2022
@cla-checker-service
Copy link

cla-checker-service bot commented May 3, 2022

💚 CLA has been signed

@elasticmachine
Copy link
Collaborator

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-03T15:47:46.023+0000

  • Duration: 5 min 45 sec

Steps errors 1

Expand to view the steps failures

Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/mighty1231 return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/mighty1231 : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/mighty1231 : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mighty1231 mighty1231 closed this May 3, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 3, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-28T13:15:52.811+0000

  • Duration: 130 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 22404
Skipped 1937
Total 24341

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mighty1231 mighty1231 reopened this May 3, 2022
@mergify
Copy link
Contributor

mergify bot commented May 8, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b flag_environment upstream/flag_environment
git merge upstream/main
git push upstream flag_environment

Copy link
Contributor

@belimawr belimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mighty1231! I added only a small comment.

CHANGELOG.next.asciidoc Show resolved Hide resolved
@mighty1231 mighty1231 changed the title Fix environment flag in Dockerfile CMD Remove ambiguity on Dockerfile CMD. May 10, 2022
@mighty1231 mighty1231 requested a review from belimawr May 11, 2022 12:52
@belimawr
Copy link
Contributor

/test

@belimawr belimawr added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label May 12, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 12, 2022
@belimawr belimawr added the backport-skip Skip notification from the automated backport with mergify label May 12, 2022
@belimawr belimawr self-assigned this May 12, 2022
@mergify
Copy link
Contributor

mergify bot commented May 12, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b flag_environment upstream/flag_environment
git merge upstream/main
git push upstream flag_environment

kvch
kvch previously approved these changes May 12, 2022
belimawr
belimawr previously approved these changes May 16, 2022
@belimawr
Copy link
Contributor

this E2E tests seem to be stuck :/

@belimawr
Copy link
Contributor

/test

@belimawr
Copy link
Contributor

@mergify help

@mergify
Copy link
Contributor

mergify bot commented May 18, 2022

Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@belimawr
Copy link
Contributor

I think those E2E tests are not in this branch yet, I'll ask mergify to rebase this PR onto main.

@belimawr
Copy link
Contributor

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented May 18, 2022

rebase

✅ Branch has been successfully rebased

@belimawr
Copy link
Contributor

/test

2 similar comments
@belimawr
Copy link
Contributor

/test

@belimawr
Copy link
Contributor

/test

@belimawr
Copy link
Contributor

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented May 24, 2022

rebase

✅ Branch has been successfully rebased

@dadoonet dadoonet force-pushed the flag_environment branch from d02a5cb to 36f60ff Compare May 24, 2022 06:48
@rdner
Copy link
Member

rdner commented Jun 2, 2022

/test

@belimawr
Copy link
Contributor

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2022

rebase

✅ Branch has been successfully rebased

@mergify
Copy link
Contributor

mergify bot commented Jul 11, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b flag_environment upstream/flag_environment
git merge upstream/main
git push upstream flag_environment

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b flag_environment upstream/flag_environment
git merge upstream/main
git push upstream flag_environment

@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2023

help

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b flag_environment upstream/flag_environment
git merge upstream/main
git push upstream flag_environment

@v1v v1v dismissed stale reviews from belimawr and kvch via 89602bb May 8, 2023 08:36
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b flag_environment upstream/flag_environment
git merge upstream/main
git push upstream flag_environment

@cmacknz
Copy link
Member

cmacknz commented Jun 27, 2023

Closing. Re-open when ready for re-review.

@cmacknz cmacknz closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants