Remove libbeat/metric and use github.com/elastic/elastic-agent-system-metrics instead

[kvch]

What does this PR do?

This PR removes the folder libbeat/metric and imports the same functionality from github.com/elastic/elastic-agent-system-metrics.

I am not fixing linter issues.

Why is it important?

Avoid maintaining the same code in different places.

Checklist

• My code follows the style guidelines of this project
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have made corresponding changes to the documentation
  - [ ] I have made corresponding change to the default configuration files
  - [ ] I have added tests that prove my fix is effective or that my feature works
  - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b use-system-metrics-lib upstream/use-system-metrics-lib
git merge upstream/main
git push upstream use-system-metrics-lib

[elasticmachine]

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-05-20T15:45:47.213+0000

• Duration: 107 min 42 sec

Test stats 🧪

Test	Results
Failed	1
Passed	22190
Skipped	1933
Total	24124

Test errors

Expand to view the tests failures

Build&Test / metricbeat-goIntegTest / TestFetch – github.com/elastic/beats/v7/metricbeat/module/mongodb/replstatus

Expand to view the error details

 Failed 

Expand to view the stacktrace

 === RUN   TestFetch
    replstatus_integration_test.go:53: Expected 0 error, had 1. [error getting replication status: error running command 'replSetGetStatus' on admin db: (InvalidReplicaSetConfig) Our replica set config is invalid or we are not a member of it]
--- FAIL: TestFetch (9.83s)
 

Steps errors

Expand to view the steps failures

metricbeat-goIntegTest - mage goIntegTest

• Took 30 min 41 sec . View more details here
• Description: mage goIntegTest

metricbeat-goIntegTest - mage goIntegTest

• Took 20 min 3 sec . View more details here
• Description: mage goIntegTest

metricbeat-goIntegTest - mage goIntegTest

• Took 20 min 21 sec . View more details here
• Description: mage goIntegTest

Error signal

• Took 0 min 0 sec . View more details here
• Description: Error 'hudson.AbortException: script returned exit code 1'

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

• Name: Build&Test / metricbeat-goIntegTest / TestFetch – github.com/elastic/beats/v7/metricbeat/module/mongodb/replstatus

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[fearful-symmetry]

quick thing: The stuff in metricbeat/internal also needs to be removed and migrated to elastic-agent-system-metrics as well. It's fundamentally the same as the metrics in libbeat/, the code just dates to a time when we weren't sure where system metrics were supposed to live.

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b use-system-metrics-lib upstream/use-system-metrics-lib
git merge upstream/main
git push upstream use-system-metrics-lib

[elasticmachine]

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

[cmacknz]

As usual I just spot checked this, we'll have to rely on CI to find any unexpected problems.

[kvch]

I will fix crosscompiling issues in elastic-agent-system-metrics.

[fearful-symmetry]

@kvch just to make sure I'm on the same page, is the plan to migrate + remove the metrics code in libbeat/internal in a different set of PRs?

[kvch]

just to make sure I'm on the same page, is the plan to migrate + remove the metrics code in libbeat/internal in a different set of PRs?

Yes. If that works for you.

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b use-system-metrics-lib upstream/use-system-metrics-lib
git merge upstream/main
git push upstream use-system-metrics-lib

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b use-system-metrics-lib upstream/use-system-metrics-lib
git merge upstream/main
git push upstream use-system-metrics-lib

[elasticmachine]

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)