Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Update agent-complete node version to 16.15.0 #31675

Merged
merged 2 commits into from
May 21, 2022

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented May 19, 2022

We've been on an old node version for a while, this is the latest LTS version.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

We've been on an old node version for a while, this is the latest LTS
version.
@andrewvc andrewvc added enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels May 19, 2022
@andrewvc andrewvc requested a review from a team as a code owner May 19, 2022 00:47
@andrewvc andrewvc self-assigned this May 19, 2022
@andrewvc andrewvc requested review from cmacknz and kvch and removed request for a team May 19, 2022 00:47
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 19, 2022
@andrewvc andrewvc marked this pull request as draft May 19, 2022 00:47
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 19, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-20T21:16:36.155+0000

  • Duration: 203 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 22288
Skipped 1933
Total 24221

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc andrewvc merged commit d38dadb into elastic:main May 21, 2022
@justinkambic
Copy link
Contributor

Discussed with @andrewvc offline and we agreed this can skip Post-FF testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants