Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force DEV=0 when cross-compiling to darwin/amd64 #32274

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Jul 8, 2022

This is a work around for elastic/golang-crossbuild#217 where the package target is broken when setting DEV=1 with the Go 1.17.11 crossbuild image.

I have also un-reverted the change for #31955 since it was not actually the root cause. It does not cause any issues when tested locally using the Go 1.17.10 image that is known to work.

@cmacknz cmacknz added ci Team:Automation Label for the Observability productivity team build-system Issue or change affecting Mage, Make, or build scripts. Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jul 8, 2022
@cmacknz cmacknz requested a review from a team as a code owner July 8, 2022 15:04
@cmacknz cmacknz removed the request for review from a team July 8, 2022 15:04
@cmacknz cmacknz self-assigned this Jul 8, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 8, 2022
@cmacknz
Copy link
Member Author

cmacknz commented Jul 8, 2022

/package

@cmacknz
Copy link
Member Author

cmacknz commented Jul 8, 2022

Packaging succeeded (https://beats-ci.elastic.co/job/Beats/job/packaging/job/PR-32274/2/) and the E2E test job is known to be flaky. Merging this to unblock everybody's builds.

@cmacknz cmacknz merged commit ff67063 into elastic:main Jul 8, 2022
@cmacknz cmacknz deleted the disable-dev-builds-osx-crossbuild branch July 8, 2022 16:59
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-08T15:05:05.284+0000

  • Duration: 117 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 22413
Skipped 1937
Total 24350

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* Force DEV=0 when cross compiling for darwin/amd64.

elastic/golang-crossbuild#217

* Revert "Revert "Fix flags for dev build (#31955)" (#32250)"

This reverts commit ba5d0cb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-system Issue or change affecting Mage, Make, or build scripts. ci Team:Automation Label for the Observability productivity team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants