-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add .python-verson file #32323
add .python-verson file #32323
Conversation
Add .python-version file with the same version we're using on CI.
119cbf2
to
3e1622d
Compare
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
I've just realised that
But it works file with Python 3.9.13
Should we set our Python version to 3.9.13? @cmacknz Any thoughts here? I'll update to 3.9.13 and see if it changes anything on CI. |
Because this didn't change any of the source files I don't think it actually triggered any of the tests: https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-32323/4/pipeline We probably have to do it manually. No opposition to this as long as it doesn't break anything. |
/test |
/test filebeat |
/test libbeat |
/package |
Add .python-version file pinning Python used on tests to 3.9.13. .python-version is also removed from .gitignore
What does this PR do?
Add .python-version file with the same version we're using on CI.
Why is it important?
It documents which Python version should be used an allows for the use of pyenv to manage the Python version automatically.
Currently our system tests are not compatible with Python >= 3.10.0
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.## Author's ChecklistHow to test this PR locally
Install Pyenv and run
The output should state that the Python version is set by the
.python-version
file on the root of this repository.## Related issuesUse cases
Any engineer trying to run system tests on a system with Python >= 3.10
## Screenshots## Logs