-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ironbank: support for heartbeat #32502
Conversation
x-pack/heartbeat/Jenkinsfile.yml
Outdated
@@ -27,6 +27,9 @@ stages: | |||
goIntegTest: | |||
mage: "mage goIntegTest" | |||
stage: mandatory | |||
validateIronbank: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This stage is the one to validate the ironbank for heartbeat
are compliance. If it fails then, look at the README.md in the ironbank
folder that contains enough details to handle what's required to be done
@@ -0,0 +1,92 @@ | |||
https://ftp.plusline.net/rockylinux/8.6/BaseOS/x86_64/os/Packages/f/fontconfig-2.13.1-4.el8.x86_64.rpm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those dependencies are the ones defined in https://repo1.dso.mil/dsop/elastic/beats/heartbeat/-/blob/development/hardening_manifest.yaml (more precisely the ones defined in https://repo1.dso.mil/dsop/elastic/beats/heartbeat/-/merge_requests/43)
since it requires the tar.gz from the mage package
…nd the stack works as expected
This PR won't be needed since the ironbank validation for the heartbeats will run somewhere else as agreed with @jlind23 and @cachedout
The above was discussed in an internal GitHub issue, so only elasticians have access and it's linked to this particular PR. A new PR will be done shortly |
🚧
Motivation/summary
Automate the docker context generation for the Heartbeat IronBank releases, this will allow us to move away from creating those docker context manually in a different repository, since the Platform Release team already provide the automation.
Implementation details
mage ironbank
mage validateIronbank
The CI will validate the Ironbank as part of the
packaging-linux
since it requires:heartbeat-xxxx.tar.gz
file to be generated (as part of the mage package)DoD build context content
As required the build context contains the following files:
Dockerfile
with specific requirements for DoD (registry args, no internet dependencies, healthcheck, ...)hardening_manifest.yaml
with all required dependenciesLICENSE
specific for DoDREADME.md
with specific content for DoDconfig/
(optional) directory containing all config files to include into the Docker imagescripts/
directory containing all scripts to include into the Docker image (example: entrypoint...)Why is it important?
No more manual post-release steps to generate the ironbank releases for heartbeat
Actions
tar.gz
docker context following the Unified Release requirementshardening_manifest.yaml
that includes all the dependencies.Issues
A similar approach was done for other beats.