Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action: checks for filebeat and x-pack/filebeat #32746

Merged
merged 9 commits into from
Aug 25, 2022
Merged

action: checks for filebeat and x-pack/filebeat #32746

merged 9 commits into from
Aug 25, 2022

Conversation

v1v
Copy link
Member

@v1v v1v commented Aug 22, 2022 •
edited
Loading

What does this PR do?

Use GitHub actions to run the check stage for filebeat and x-pack/filebeat

What's the check stage?

  • make check
  • make update
  • make check-no-changes
  • mage check
  • mage update

Why is it important?

Faster builds by running linting/checks outside of the main CI Pipeline.

Errors

Errors

libpcap-dev solves the issue with:

Error: /home/runner/go/pkg/mod/github.com/elastic/gopacket@v1.1.20-0.20211202005954-d412fca7f83a/pcap/pcap_unix.go:34:10: fatal error: pcap.h: No such file or directory
   34 | #include <pcap.h>
      |          ^~~~~~~~
compilation terminated.

libsystemd-dev solves the issue with:

# github.com/coreos/go-systemd/v22/sdjournal
Error: ../../../../go/pkg/mod/github.com/coreos/go-systemd/v22@v22.3.2/sdjournal/journal.go:27:11: fatal error: systemd/sd-journal.h: No such file or directory
   27 | // #include <systemd/sd-journal.h>
      |           ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Further details

The existing checks in Jenkins are replaced with GitHub checks, hence the union of these 2 new Github workflows substitutes each former check. Therefore, the same commands will run for the same scenarios.

Results

Nearly 10 minutes since they build was triggered in Jenkins and still waiting for workers to be assigned, while the new GitHub checks finished relatively much faster

Related issues

Similar to #32711

@v1v v1v added automation Team:Automation Label for the Observability productivity team backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.4.0 Automated backport with mergify labels Aug 22, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 22, 2022
@mergify mergify bot assigned v1v Aug 22, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 22, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-24T16:30:24.522+0000

  • Duration: 129 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 8547
Skipped 909
Total 9456

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v v1v requested a review from a team August 22, 2022 16:33
@v1v v1v marked this pull request as ready for review August 22, 2022 16:34
@v1v v1v requested a review from a team as a code owner August 22, 2022 16:34
@v1v v1v requested review from belimawr and rdner and removed request for a team August 22, 2022 16:34
@v1v
As stated in the code review
6be7b49 
use v3 and avoid latest in favour of go.sum
@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/check-actions-filebeat-modules upstream/feature/check-actions-filebeat-modules
git merge upstream/main
git push upstream feature/check-actions-filebeat-modules

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/check-actions-filebeat-modules upstream/feature/check-actions-filebeat-modules
git merge upstream/main
git push upstream feature/check-actions-filebeat-modules

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/check-actions-filebeat-modules upstream/feature/check-actions-filebeat-modules
git merge upstream/main
git push upstream feature/check-actions-filebeat-modules

@v1v v1v merged commit da20ec7 into elastic:main Aug 25, 2022
@mergify mergify bot mentioned this pull request Aug 25, 2022
Merged
mergify bot pushed a commit that referenced this pull request Aug 25, 2022
@v1v @mergify
action: checks for filebeat and x-pack/filebeat (#32746)
82c9723 
(cherry picked from commit da20ec7)

# Conflicts:
#	.github/workflows/opentelemetry.yml
#	filebeat/Jenkinsfile.yml
#	x-pack/filebeat/Jenkinsfile.yml
@mergify mergify bot mentioned this pull request Aug 25, 2022
Merged
mergify bot pushed a commit that referenced this pull request Aug 25, 2022
@v1v @mergify
action: checks for filebeat and x-pack/filebeat (#32746)
e2dd7fd 
(cherry picked from commit da20ec7)

# Conflicts:
#	.github/workflows/opentelemetry.yml
v1v pushed a commit that referenced this pull request Aug 25, 2022
@mergify
[7.17](backport #32746) action: checks for filebeat and x-pack/filebe…
b7e7860 
…at (#32837)
v1v pushed a commit that referenced this pull request Aug 25, 2022
@mergify
action: checks for filebeat and x-pack/filebeat (#32746) (#32838)
3583d6e
v1v added a commit to v1v/beats that referenced this pull request Sep 1, 2022
@v1v
Merge remote-tracking branch 'upstream/main' into feature/heartbeat-p…
a884d74 
…ackaging

* upstream/main: (109 commits)
  Add cap_net_raw requirements to heartbeat docs (elastic#32816)
  apply a quick hotfix for having main working properly (elastic#32934)
  action: checks for x-pack/libbeat and libbeat (elastic#32754)
  Update to Go 1.18 in go.mod. (elastic#32940)
  [heartbeat] disable browser code on windows via build tags (elastic#32939)
  action: checks for heartbeat and x-pack/heartbeat (elastic#32749)
  Make event acknowledgment asynchronous in shipper output (elastic#32785)
  [Automation] Update elastic stack version to 8.5.0-fedc3e60 for testing (elastic#32930)
  Preallocate memory to reduce GC load (elastic#32905)
  [Automation] Update elastic stack version to 8.5.0-440e0896 for testing (elastic#32919)
  Skip broken ceph tests. (elastic#32912)
  Use non-deprecated docker image for testing jolokia (elastic#32885)
  update ironbank image product name (elastic#32867)
  ci: pre-commit stage within Jenkins (elastic#32839)
  Fix a couple of bugs in the logic for how AWS metric periods are calculated (elastic#32724)
  [Filebeat] [httpjson] Add support for single string containing multiple relation-types in getRFC5988Link (elastic#32811)
  [Heartbeat] Update HB k8s template to use <Mi> metric (elastic#32801)
  action: checks for metricbeat and x-pack/metricbeat (elastic#32748)
  action: checks for filebeat and x-pack/filebeat (elastic#32746)
  allow for json/ndjson content type with charset (elastic#32767)
  ...
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@v1v @chrisberkhout
action: checks for filebeat and x-pack/filebeat (#32746)
d998bc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdner rdner rdner approved these changes

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@v1v v1v

Labels
automation backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.4.0 Automated backport with mergify Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v1v @elasticmachine @rdner