Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Fix GCP Storage field #32806

Merged
merged 5 commits into from
Sep 9, 2022
Merged

[Metricbeat] Fix GCP Storage field #32806

merged 5 commits into from
Sep 9, 2022

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Aug 24, 2022

What does this PR do?

Fixes GCP storage field authz.acl_based_object_access.count in fields.yml.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 24, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @gpop63? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@mergify mergify bot assigned gpop63 Aug 24, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 24, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-08T13:41:57.162+0000

  • Duration: 68 min 58 sec

Test stats 🧪

Test Results
Failed 0
Passed 4046
Skipped 999
Total 5045

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@gpop63 gpop63 marked this pull request as ready for review August 25, 2022 09:35
@gpop63 gpop63 requested a review from a team as a code owner August 25, 2022 09:35
@endorama endorama added backport-7.17 Automated backport to the 7.17 branch with mergify Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Aug 25, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 25, 2022
@endorama
Copy link
Member

Added backport for 7.17 as this is a bugfix.

endorama
endorama requested changes Aug 25, 2022
View reviewed changes
Copy link
Member

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs a changelog entry but everything else LGTM

@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix_gcp_storage_field upstream/fix_gcp_storage_field
git merge upstream/main
git push upstream fix_gcp_storage_field

@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix_gcp_storage_field upstream/fix_gcp_storage_field
git merge upstream/main
git push upstream fix_gcp_storage_field

endorama
endorama requested changes Sep 7, 2022
View reviewed changes
@gpop63 gpop63 merged commit 8156cdd into elastic:main Sep 9, 2022
mergify bot pushed a commit that referenced this pull request Sep 9, 2022
@gpop63 @mergify
[Metricbeat] Fix GCP Storage field (#32806)
52d5e2e 
* fix field

* fix docs and fields

* add changelog entry in bug fixes

Co-authored-by: Edoardo Tenani <526307+endorama@users.noreply.github.com>
(cherry picked from commit 8156cdd)

# Conflicts:
#	x-pack/metricbeat/module/gcp/fields.go
@mergify mergify bot mentioned this pull request Sep 9, 2022
Merged
gpop63 added a commit that referenced this pull request Sep 27, 2022
@mergify @gpop63
[7.17](backport #32806) [Metricbeat] Fix GCP Storage field (#33034)
9a1d4c8 
* [Metricbeat] Fix GCP Storage field (#32806)

* fix field

* fix docs and fields

* add changelog entry in bug fixes

Co-authored-by: Edoardo Tenani <526307+endorama@users.noreply.github.com>
(cherry picked from commit 8156cdd)

# Conflicts:
#	x-pack/metricbeat/module/gcp/fields.go

* Update fields.go

* fix fields

Co-authored-by: Gabriel Pop <94497545+gpop63@users.noreply.github.com>
Co-authored-by: gab <gabriel.pop@elastic.co>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@gpop63 @endorama @chrisberkhout
[Metricbeat] Fix GCP Storage field (#32806)
1891339 
* fix field

* fix docs and fields

* add changelog entry in bug fixes

Co-authored-by: Edoardo Tenani <526307+endorama@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endorama endorama endorama approved these changes

Assignees

@gpop63 gpop63

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify bugfix Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gpop63 @elasticmachine @endorama