Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17](backport #32724) Fix a couple of bugs in the logic for how AWS metric periods are calculated #32871

Merged
merged 1 commit into from
Aug 26, 2022

Commits on Aug 25, 2022

  1. Fix a couple of bugs in the logic for how AWS metric periods are calc…

    …ulated (#32724)
    
    * Fix a couple of bugs in the logic for how AWS metric periods are calcuated.
    
    Firstly, we clarify that periods are always whole-minute durations.
    Any period that is less than or in between minutes is rounded up to the
    next whole-minute.
    
    Secondly, we ensure that the resulting time period is always in the past.
    This stops us getting empty metrics for the current-minute period.
    
    Thirdly, we follow the AWS guidelines of aligning periods to whole
    multiples within the hour e.g. 10:25->10:30 instead of 10:27->10:32
    for a 5 minute period.
    
    * add test that validates intervals are continuous for given periods
    
    * update changelog
    
    * fix merge error
    
    (cherry picked from commit df3733e)
    tommyers-elastic authored and mergify[bot] committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    a6601a6 View commit details
    Browse the repository at this point in the history