-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.17](backport #31001) Filesystem refactor #33022
Conversation
* first pass at filesystem refactoring * cleanup code * final cleanup * cleanup, docs * license headers * make linter happy * try to hack around linter platform issues * fix function sig * minor fixes, formatting * try to make linter happy * more linter fixes * hopefully the last linter cleanup * try to fix unit tests * fix tests * refactor after merges from elastic-agent libs * make linter happy * try to update deps * okay, try that * fix merge * add changelog, revert opt changes * fix broken merge * mage update (cherry picked from commit 1d4a7ca) # Conflicts: # go.sum # metricbeat/module/system/fields.go # metricbeat/module/system/filesystem/_meta/fields.yml # metricbeat/module/system/filesystem/filesystem.go # metricbeat/module/system/filesystem/filesystem_test.go # metricbeat/module/system/filesystem/helper.go # metricbeat/module/system/fsstat/fsstat.go # metricbeat/module/system/test_system.py
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request has not been merged yet. Could you please review and merge it @fearful-symmetry? 🙏 |
Tests are still failing, not quite sure why. |
Alright, tested this manually. If there's still dependency issues I'm just gonna merge this |
This pull request has not been merged yet. Could you please review and merge it @fearful-symmetry? 🙏 |
This is an automatic backport of pull request #31001 done by Mergify.
Cherry-pick of 1d4a7ca has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com