Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auditbeat/module/file_integrity: improve documentation and ensure paths are absolute #33430

Merged
merged 1 commit into from
Oct 25, 2022
Merged

auditbeat/module/file_integrity: improve documentation and ensure paths are absolute #33430

merged 1 commit into from
Oct 25, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Oct 21, 2022

What does this PR do?

This clarifies the behaviour of the auditbeat file integrity module in its handling of symlinks and ensures that the current documented behaviour of resolving path to their absolute path where possible is honored.

Why is it important?

The current documentation has been confusing for some users because is does not specify the behaviour wrt the handling of symlinks, and the current documented behaviour is not honored wrt absolute path resolution.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added Auditbeat Team:Security-External Integrations backport-7.17 Automated backport to the 7.17 branch with mergify 8.6 candidate labels Oct 21, 2022
@efd6 efd6 self-assigned this Oct 21, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 21, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 21, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-24T22:51:57.173+0000

  • Duration: 42 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 573
Skipped 81
Total 654

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review October 21, 2022 10:56
@efd6 efd6 requested a review from a team as a code owner October 21, 2022 10:56
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

andrewkroh
andrewkroh approved these changes Oct 24, 2022
View reviewed changes
@efd6 efd6 merged commit 749e708 into elastic:main Oct 25, 2022
@mergify mergify bot mentioned this pull request Oct 25, 2022
Merged
mergify bot pushed a commit that referenced this pull request Oct 25, 2022
@efd6 @mergify
auditbeat/module/file_integrity: improve documentation and ensure pat…
64576a3 
…hs are absolute (#33430)

(cherry picked from commit 749e708)
efd6 added a commit that referenced this pull request Oct 25, 2022
@mergify @efd6
auditbeat/module/file_integrity: improve documentation and ensure pat…
4bf962f 
…hs are absolute (#33430) (#33448)

(cherry picked from commit 749e708)

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@efd6 @chrisberkhout
auditbeat/module/file_integrity: improve documentation and ensure pat…
3d4956b 
…hs are absolute (#33430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@efd6 efd6

Labels
8.6 candidate Auditbeat backport-7.17 Automated backport to the 7.17 branch with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @andrewkroh