Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register the add_formatted_index as a usable processor. #33800

Merged
merged 8 commits into from
Nov 28, 2022
Merged

Register the add_formatted_index as a usable processor. #33800

merged 8 commits into from
Nov 28, 2022

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Nov 23, 2022 •
edited
Loading

What does this PR do?

Registers the add_formatted_index processor that was original only an internal processor as a usable processor in the configuration.

Why is it important?

This allows the destination index for an event to be changed after other processors have ran. Without it the original index field generates the add_formatted_index processor internally but is always the first processor to run. This allows the index to be changed after other processors which is needed for architecture V2 change for the Elastic Agent.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Building x-pack/filebeat and using this PR for the Elastic Agent will show how the content of a log file can adjust the resulting index.

elastic/elastic-agent#1702

Related issues

@blakerouse blakerouse added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Nov 23, 2022
@blakerouse blakerouse self-assigned this Nov 23, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 23, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 23, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @blakerouse? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@blakerouse blakerouse added the backport-v8.6.0 Automated backport with mergify label Nov 23, 2022
@blakerouse blakerouse marked this pull request as ready for review November 23, 2022 20:34
@blakerouse blakerouse requested a review from a team as a code owner November 23, 2022 20:34
@blakerouse blakerouse requested review from rdner and cmacknz and removed request for a team November 23, 2022 20:34
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@blakerouse blakerouse mentioned this pull request Nov 23, 2022
Merged
5 tasks
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 23, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-28T18:36:56.135+0000

  • Duration: 86 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 24114
Skipped 1954
Total 26068

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cmacknz
Copy link
Member

cmacknz commented Nov 28, 2022

You will likely need the changes in #33789 to get CI to pass.

michalpristas
michalpristas approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blakerouse blakerouse merged commit 4c4eecf into elastic:main Nov 28, 2022
@blakerouse blakerouse deleted the add_formatted_index-processor branch November 28, 2022 20:11
@mergify mergify bot mentioned this pull request Nov 28, 2022
Merged
mergify bot pushed a commit that referenced this pull request Nov 28, 2022
@blakerouse @mergify
Register the add_formatted_index as a usable processor. (#33800)
ee8a9bb 
* Register the add_formatted_index as a usage processor for the processors list.

* Re-add removed file.

* Add changelog entry.

* Add missing return in String().

* Change implementation to use a boolean.

(cherry picked from commit 4c4eecf)
blakerouse added a commit that referenced this pull request Nov 29, 2022
@mergify @blakerouse
Register the add_formatted_index as a usable processor. (#33800) (#33846
b9a0c53 
)

* Register the add_formatted_index as a usage processor for the processors list.

* Re-add removed file.

* Add changelog entry.

* Add missing return in String().

* Change implementation to use a boolean.

(cherry picked from commit 4c4eecf)

Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@blakerouse @chrisberkhout
Register the add_formatted_index as a usable processor. (#33800)
cb0eb64 
* Register the add_formatted_index as a usage processor for the processors list.

* Re-add removed file.

* Add changelog entry.

* Add missing return in String().

* Change implementation to use a boolean.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas approved these changes

@cmacknz cmacknz cmacknz approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman

Assignees

@blakerouse blakerouse

Labels
backport-v8.6.0 Automated backport with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blakerouse @elasticmachine @cmacknz @michalpristas