Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.4](backport #34075) [azure-eventhub input] Switch the run EPH run mode to non-blocking #34099

Merged
merged 2 commits into from
Dec 29, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 22, 2022

This is an automatic backport of pull request #34075 done by Mergify.
Cherry-pick of 8f0db84 has failed:

On branch mergify/bp/8.4/pr-34075
Your branch is up to date with 'origin/8.4'.

You are currently cherry-picking commit 8f0db84225.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.next.asciidoc
	modified:   x-pack/filebeat/input/azureeventhub/eph.go
	modified:   x-pack/filebeat/input/azureeventhub/eph_test.go
	modified:   x-pack/filebeat/input/azureeventhub/input.go
	modified:   x-pack/filebeat/input/azureeventhub/input_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   x-pack/libbeat/management/generate_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…34075)

* Start EPH as non-blocking

With this change, the first call to the input Start() method will set up and start the EPH worker in a non-blocking fashion. The EPH worker will continue until the Filebeat calls the Stop() method to tear it down for live reloading.

(cherry picked from commit 8f0db84)

# Conflicts:
#	x-pack/libbeat/management/generate_test.go
@mergify mergify bot requested a review from a team as a code owner December 22, 2022 14:28
@mergify mergify bot requested review from rdner and cmacknz and removed request for a team December 22, 2022 14:28
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Dec 22, 2022
@mergify mergify bot assigned zmoog Dec 22, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 22, 2022
@botelastic
Copy link

botelastic bot commented Dec 22, 2022

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 22, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-22T15:28:18.964+0000

  • Duration: 71 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 2188
Skipped 166
Total 2354

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mergify
Copy link
Contributor Author

mergify bot commented Dec 26, 2022

This pull request has not been merged yet. Could you please review and merge it @zmoog? 🙏

@zmoog zmoog merged commit c7e14a2 into 8.4 Dec 29, 2022
@zmoog zmoog deleted the mergify/bp/8.4/pr-34075 branch December 29, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants