Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat][Kubernetes] Update proxy, scheduler and controller manager dashboards #34237

Merged
merged 3 commits into from
Jan 13, 2023
Merged

[Metricbeat][Kubernetes] Update proxy, scheduler and controller manager dashboards #34237

merged 3 commits into from
Jan 13, 2023

Conversation

constanca-m
Copy link
Contributor

@constanca-m constanca-m commented Jan 11, 2023 •
edited
Loading

What does this PR do?

Following the comments on elastic/integrations#4948, dashboards were updated:

  • Visualization for resident memory use now average instead of rate
  • [Metricbeat Kubernetes] was removed from all titles

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Screenshots

image

@constanca-m constanca-m requested a review from a team as a code owner January 11, 2023 16:25
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 11, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 11, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @constanca-m? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@constanca-m constanca-m added Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 11, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 11, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-13T14:08:51.437+0000

  • Duration: 41 min 19 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

tetianakravchenko
tetianakravchenko approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@tetianakravchenko tetianakravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Some extra white spaces in chart names

metricbeat/module/kubernetes/_meta/kibana/7/dashboard/2ec26ce0-f5f1-11ec-8853-8b596bddf5f9.json Outdated
@@ -1777,9 +1778,9 @@
"y": 44
},
"panelIndex": "75255ce8-2d49-4b4f-ac0e-a20fe8f4daec",
"title": "Scheduler process data [Metricbeat Kubernetes]",
"title": "Controller manager process data ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Controller manager process data ",
"title": "Controller manager process data",

metricbeat/module/kubernetes/_meta/kibana/7/dashboard/2ec26ce0-f5f1-11ec-8853-8b596bddf5f9.json Outdated
@@ -1979,9 +1963,9 @@
"y": 44
},
"panelIndex": "303702e1-ba33-49f2-b337-4cc7d7305606",
"title": "Resident memory variation [Metricbeat Kubernetes]",
"title": "Average resident memory ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Average resident memory ",
"title": "Average resident memory",

metricbeat/module/kubernetes/_meta/kibana/7/dashboard/2ec26ce0-f5f1-11ec-8853-8b596bddf5f9.json Outdated
@@ -2205,9 +2189,9 @@
"y": 50
},
"panelIndex": "1604f0de-edd6-456e-8670-ab9b33988abb",
"title": "CPU usage increase over time [Metricbeat Kubernetes]",
"title": "CPU usage increase over time ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "CPU usage increase over time ",
"title": "CPU usage increase over time",

metricbeat/module/kubernetes/_meta/kibana/7/dashboard/2ec26ce0-f5f1-11ec-8853-8b596bddf5f9.json Outdated
@@ -2483,9 +2467,9 @@
"y": 65
},
"panelIndex": "fd90adaf-517f-4b92-a5b5-c29f7a16663b",
"title": "Leader controller manager [Metricbeat Kubernetes]",
"title": "Leader controller manager ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Leader controller manager ",
"title": "Leader controller manager",

metricbeat/module/kubernetes/_meta/kibana/7/dashboard/2ec26ce0-f5f1-11ec-8853-8b596bddf5f9.json Outdated
@@ -3061,19 +3045,20 @@
"y": 71
},
"panelIndex": "1bd24fa1-319e-4cae-9d45-d821b06a8034",
"title": "Average request latency [Metricbeat Kubernetes]",
"title": "Average request latency ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Average request latency ",
"title": "Average request latency",

metricbeat/module/kubernetes/_meta/kibana/7/dashboard/5e649d60-9901-11e9-ba57-b7ab4e2d4b58.json Outdated
@@ -601,9 +602,9 @@
"y": 7
},
"panelIndex": "34de2f11-faf2-49e8-aada-98c2cd5eb266",
"title": "Average SyncProxyRules latency [Metricbeat Kubernetes]",
"title": "Average SyncProxyRules latency ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Average SyncProxyRules latency ",
"title": "Average SyncProxyRules latency",

metricbeat/module/kubernetes/_meta/kibana/7/dashboard/5e649d60-9901-11e9-ba57-b7ab4e2d4b58.json Outdated
@@ -1195,9 +1179,9 @@
"y": 24
},
"panelIndex": "303702e1-ba33-49f2-b337-4cc7d7305606",
"title": "Resident memory variation [Metricbeat Kubernetes]",
"title": "Average resident memory ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Average resident memory ",
"title": "Average resident memory",

metricbeat/module/kubernetes/_meta/kibana/7/dashboard/5e649d60-9901-11e9-ba57-b7ab4e2d4b58.json Outdated
@@ -1396,9 +1380,9 @@
"y": 33
},
"panelIndex": "1604f0de-edd6-456e-8670-ab9b33988abb",
"title": "CPU usage increase over time [Metricbeat Kubernetes]",
"title": "CPU usage increase over time ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "CPU usage increase over time ",
"title": "CPU usage increase over time",

@MichaelKatsoulis MichaelKatsoulis mentioned this pull request Jan 12, 2023
Merged
@constanca-m
Remove empty spaces.
3c3ce7b 
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m added the backport-v8.6.0 Automated backport with mergify label Jan 12, 2023
@constanca-m
Copy link
Contributor Author

/test

@constanca-m constanca-m merged commit 3a3fbd4 into elastic:main Jan 13, 2023
@constanca-m constanca-m deleted the fix-dashboards branch January 13, 2023 14:52
@mergify mergify bot mentioned this pull request Jan 13, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jan 13, 2023
@constanca-m @mergify
[Metricbeat][Kubernetes] Update proxy, scheduler and controller manag…
c691e45 
…er dashboards (#34237)

* Update dashboards

* Add correct title to dashboard.

* Remove empty spaces.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
(cherry picked from commit 3a3fbd4)
constanca-m added a commit that referenced this pull request Jan 13, 2023
@mergify @constanca-m
[Metricbeat][Kubernetes] Update proxy, scheduler and controller manag…
28d5905 
…er dashboards (#34237) (#34258)

* Update dashboards

* Add correct title to dashboard.

* Remove empty spaces.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
(cherry picked from commit 3a3fbd4)

Co-authored-by: Constança Manteigas <113898685+constanca-m@users.noreply.github.com>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@constanca-m @chrisberkhout
[Metricbeat][Kubernetes] Update proxy, scheduler and controller manag…
e3f9293 
…er dashboards (#34237)

* Update dashboards

* Add correct title to dashboard.

* Remove empty spaces.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetianakravchenko tetianakravchenko tetianakravchenko approved these changes

@gizas gizas Awaiting requested review from gizas

Assignees

@constanca-m constanca-m

Labels
backport-v8.6.0 Automated backport with mergify enhancement Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@constanca-m @elasticmachine @tetianakravchenko