Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17](backport #2246) Enable verification with alternative PGP keys #34604

Merged
merged 7 commits into from
Feb 20, 2023

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas added bug backport Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Feb 16, 2023
@michalpristas michalpristas self-assigned this Feb 16, 2023
@michalpristas michalpristas requested a review from a team as a code owner February 16, 2023 16:11
@michalpristas michalpristas requested review from blakerouse and michel-laterman and removed request for a team February 16, 2023 16:11
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 16, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 16, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-20T13:31:40.184+0000

  • Duration: 117 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 6243
Skipped 396
Total 6639

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pchila
Copy link
Member

pchila commented Feb 20, 2023

State of testing:

Upgrade to 8.7.0-SNAPSHOT using a modified agent built with a different GPG pub key

  • base ( no extra pgp bits specified) ✔️ : (upgrade failure is expected)
  root@pchila-elastic:/opt/Elastic/Agent# sudo elastic-agent upgrade 8.7.0-SNAPSHOT
  The upgrade process of Elastic Agent is currently EXPERIMENTAL and should not be used in production
  Error: Failed trigger upgrade of daemon: failed verification of agent binary: 3 errors occurred:
          * fetching asc file from '/opt/Elastic/Agent/data/elastic-agent-6d57e2/downloads/elastic-agent-8.7.0-SNAPSHOT-linux-x86_64.tar.gz.asc': open /opt/Elastic/Agent/data/elastic-agent-6d57e2/downloads/elastic-a
gent-8.7.0-SNAPSHOT-linux-x86_64.tar.gz.asc: no such file or directory
          * openpgp: signature made by unknown entity
          * fetching asc file from https://artifacts.elastic.co/downloads/beats/elastic-agent/elastic-agent-8.7.0-SNAPSHOT-linux-x86_64.tar.gz.asc: call to 'https://artifacts.elastic.co/downloads/beats/elastic-agent
/elastic-agent-8.7.0-SNAPSHOT-linux-x86_64.tar.gz.asc' returned unsuccessful status code: 404


For help, please see our troubleshooting guide at https://www.elastic.co/guide/en/fleet/7.17/fleet-troubleshooting.html
  • pgp-path ✔️ :
root@pchila-elastic:/opt/Elastic/Agent# sudo elastic-agent upgrade --pgp-path=/home/paolo/dev/beats/x-pack/elastic-agent/GPG-KEY-elasticsearch  8.7.0-SNAPSHOT
The upgrade process of Elastic Agent is currently EXPERIMENTAL and should not be used in production
Upgrade triggered to version 8.7.0-SNAPSHOT, Elastic Agent is currently restarting
  • pgp-uri -> ✔️
root@pchila-elastic:/opt/Elastic/Agent# ./elastic-agent upgrade --pgp-uri=https://artifacts.elastic.co/GPG-KEY-elasticsearch 8.7.0-SNAPSHOT
The upgrade process of Elastic Agent is currently EXPERIMENTAL and should not be used in production
Upgrade triggered to version 8.7.0-SNAPSHOT, Elastic Agent is currently restarting
  • pgp -> ✔️
root@pchila-elastic:/opt/Elastic/Agent# ./elastic-agent upgrade --pgp="
> -----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG v2.0.14 (GNU/Linux)

mQENBFI3HsoBCADXDtbNJnxbPqB1vDNtCsqhe49vFYsZN9IOZsZXgp7aHjh6CJBD
...
...
...
vM5w8cgvJoAwsp3Fn59AxWthN3XJYcnMfStkIuWgR7U2r+a210W6vnUxU4oN0PmM
-----END PGP PUBLIC KEY BLOCK-----
> " 8.7.0-SNAPSHOT
The upgrade process of Elastic Agent is currently EXPERIMENTAL and should not be used in production
Upgrade triggered to version 8.7.0-SNAPSHOT, Elastic Agent is currently restarting

@michalpristas michalpristas merged commit 24c48ce into elastic:7.17 Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants