Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task_manager_utilization metricset to Kibana metricbeat module #35027

Closed

Conversation

jonathan-buttner
Copy link

@jonathan-buttner jonathan-buttner commented Apr 5, 2023

This PR adds a new metricset to the Metricbeat kibana module. This collects the background worker utilization load from the API added in elastic/kibana#153600. We plan to use this metric for autoscaling in serverless.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • run kibana from source & ES from snapshot
  • pull down this PR, cd metricbeat
  • mage build
  • ./metricbeat modules enable kibana-xpack
  • uncomment the elasticsearch.output username/password lines in metricbeat.yml (elastic:changeme)
  • update ./modules.d/kibana-xpack.yml:
- module: kibana
  xpack.enabled: false
  period: 10s
  hosts: ["localhost:5601"]
  basepath: "abc" # whatever your base path is
  username: "elastic"
  password: "changeme"
  • ./metricbeat -e
  • create metricbeat-* data view in kibana
  • you should now be seeing some log entries which contain task_manager_utilization.load

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 5, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @jonathan-buttner? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@jonathan-buttner jonathan-buttner added Team:Core backport-skip Skip notification from the automated backport with mergify and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 5, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 5, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-27T12:30:50.874+0000

  • Duration: 49 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 4367
Skipped 885
Total 5252

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ymao1
Copy link

ymao1 commented Apr 17, 2023

/test

@ymao1
Copy link

ymao1 commented Apr 24, 2023

/test

@ymao1 ymao1 changed the title [Do not merge] Collect task manager load Collect task manager load Apr 24, 2023
@ymao1 ymao1 changed the title Collect task manager load Add task_manager_utilization metricset Apr 27, 2023
@ymao1 ymao1 changed the title Add task_manager_utilization metricset Add task_manager_utilization metricset to Kibana metricbeat module Apr 27, 2023
@ymao1
Copy link

ymao1 commented Apr 27, 2023

@elasticmachine merge upstream

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b collect-task-manager-load upstream/collect-task-manager-load
git merge upstream/main
git push upstream collect-task-manager-load

@ymao1 ymao1 closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.9-candidate backport-skip Skip notification from the automated backport with mergify Metricbeat Metricbeat Team:Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants