Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update experimental notices for 5.3 #3525

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Update experimental notices for 5.3 #3525

merged 1 commit into from
Feb 7, 2017

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Feb 3, 2017 •
edited
Loading

Changes:

  • Configuration reloading -> make beta[]
  • Filebeat symlinks -> GA
  • Filebeat harvester_limit -> GA
  • Filebeat publish_async -> experimental & deprecated
  • Using environment variables in the Configuration -> GA
  • Metricbeat ceph -> beta[]
  • Metricbeat couchbase -> beta[]
  • Metricbeat docker -> beta[]
  • Metricbeat haproxy -> GA
  • Metricbeat kafka -> beta[]
  • Metricbeat php_fpm -> beta[]
  • Metricbeat prometheus -> beta[]
  • Metricbeat cgroup -> GA <-- in a different PR (Enable cgroup metric collection by default #3519)

@tsg tsg added the in progress Pull request is currently in progress. label Feb 3, 2017
@ruflin ruflin added the v5.3.0 label Feb 6, 2017
@tsg tsg force-pushed the remove_experimentals branch 3 times, most recently from 2843b10 to dab0dcf Compare February 6, 2017 17:38
@tsg tsg added review and removed in progress Pull request is currently in progress. labels Feb 6, 2017
ruflin
ruflin approved these changes Feb 6, 2017
View reviewed changes
filebeat/crawler/crawler.go
@@ -44,7 +44,7 @@ func (c *Crawler) Start(r *registrar.Registrar, reloaderConfig *common.Config) e
}

if reloaderConfig.Enabled() {
logp.Warn("EXPERIMENTAL feature dynamic configuration reloading is enabled.")
logp.Warn("BETA feature dynamic configuration reloading is enabled.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me and Steffen discovered kind of a bug in the filebea reloading last Friday which will need some refactoring / cleanup to resolved. I'm not sure if we get this in until the release as it could touch quite a few parts. Do we have a place to mention such issues / known bugs? Just thinking if we perhaps should keep it experimental but support would probably be similar ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it still fits the Beta description. We did have Known issues in the release notes in the past, for example: https://www.elastic.co/guide/en/beats/libbeat/current/release-notes-5.0.0-alpha1.html#_known_issues

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will open a PR to the changelog to add this as known issue in case we can't fix it today.

Update experimental notices for 5.3
9154cb0 
 Configuration reloading -> beta[]
 Filebeat symlinks -> GA
 Filebeat harvester_limit -> GA
 Filebeat publish_async -> experimental & deprecated
 Using environment variables in the Configuration -> GA
 Metricbeat ceph -> beta[]
 Metricbeat couchbase -> beta[]
 Metricbeat docker -> beta[]
 Metricbeat haproxy -> GA
 Metricbeat kafka -> beta[]
 Metricbeat php_fpm -> beta[]
 Metricbeat prometheus -> beta[]

This also cleans up the CHANGELOG.
@ruflin ruflin merged commit c1cfd70 into elastic:master Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsg @ruflin