-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[filebeat][httpjson] Add http metrics to httpjson input #35392
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
922bfd2
to
0e830be
Compare
…feat/add-httpjson-metrics
…feat/add-httpjson-metrics
Added some comments from slack here to share, just a few thoughts after understanding more about how each are used. I won't cover the field namings as I feel @andrewkroh has a much better overview on that, I have no specific opinion on that part.
Except that it looks nice! Really looking forward to start visualizing this! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Do you think we have sufficient test coverage to make sure this change does not break anything?
-
Do we need a new test to make sure the metrics are collected?
This pull request is now in conflicts. Could you fix it? 🙏
|
The input has quite a lot of testing to be confident about it not breaking it.
Added a test to validate metric collection. |
…feat/add-httpjson-metrics
What does this PR do?
Adds an instrumented roundtripper to HTTPJSON http client to monitor metrics for the input.
Checklist
- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.The resulting metrics look like: