Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exclude pattern from all visualizations #3548

Merged
merged 1 commit into from
Feb 7, 2017

Conversation

monicasarbu
Copy link
Contributor

@monicasarbu monicasarbu commented Feb 7, 2017

As of the GitHub issue, exclude pattern doesn't work anymore in Kibana. This PR is removing the exclude pattern from the visualizations to fix the issue.

For the NFS errors visualization, a new search is needed after removing of the exclude pattern. The search selects all the NFS errors. We consider a NFS error if the nfs.status is different than NFS_OK and NFSERR_NOENT.

cc-ed @andrewkroh

@monicasarbu monicasarbu added in progress Pull request is currently in progress. v5.3.0 review and removed in progress Pull request is currently in progress. labels Feb 7, 2017
@monicasarbu monicasarbu changed the title Remove exclude pattern from NFS erros visualization Remove exclude pattern from all visualizations Feb 7, 2017
@tsg tsg merged commit 360a3da into elastic:master Feb 7, 2017
@tsg
Copy link
Contributor

tsg commented Feb 7, 2017

There were failures on this one, but I'm merging it because the failures are not related to the dashboards, and we need this for 5.2.1

@tsg tsg added the needs_backport PR is waiting to be backported to other branches. label Feb 7, 2017
monicasarbu added a commit to monicasarbu/beats that referenced this pull request Feb 7, 2017
@monicasarbu monicasarbu removed the needs_backport PR is waiting to be backported to other branches. label Feb 7, 2017
tsg pushed a commit that referenced this pull request Feb 7, 2017
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants