-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-pack/filebeat/module/panw Fix url scheme grok pattern #35757
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This pull request doesn't have a |
962c79b
to
bbf1378
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
bbf1378
to
f47347b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
(cherry picked from commit d359f9e)
What does this PR do?
This PR fixes the
url.scheme
grok pattern fromANY
toURIPROTO
for proper url handling.Why is it important?
If there is another reference url in the main url then the
url.domain
is broken.url.original value --> url.original vlaue "www.sportspar.de/widgets/index/refreshStatistic?requestPage=/&requestController=index&referer=https://www.google.com/" will be parsed in url.domain: "www.google.com".
Instead it should be
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Integration test has been modified and to run that
navigate to
x-path/filebeat
and run