-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-pack/filebeat/input/awss3 ; Fix nil hit panic when a getter is invoked on input metric #36101
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
da7e3aa
to
b355b43
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Pinging @elastic/obs-cloud-monitoring as a codeowner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me but I'd like to get @andrewkroh 's approval on this before merging. Thanks!
This pull request is now in conflicts. Could you fix it? 🙏
|
b1b3378
to
9ae7500
Compare
…ked on input metric (elastic#36101)
What does this PR do?
This PR fixes the panic mentioned in #36077. If an input metrics is not initialised but when a
Get
is invoked on the metric to pull data , then a nil pointer panic is caused.Why is it important?
To avoid nil pointer panics when metric getters are invoked
Checklist
- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Without this PR , when
go test -tags aws,integration -run TestInputRunSQS -v
is run fromx-pack/filebeat/input/awss3
then a nil pointer panic is caused and this PR fixes it.Related issues