Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ironbank: update the list of maintainers for the ironbank #36254

Merged
merged 8 commits into from
Aug 17, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented Aug 8, 2023

Proposed commit message

Update the list of maintainers for the ironbank, so it reflects the new org.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

cd x-pack/metricbeat
mage package
make -C ironbank package
mage ironbank

Then you will see the .tar.gz in the build/distributions folder for each subscribed beat, and hardening_manifest.yaml will contain the new up-to-date list of maintainers

Related issues

#32251 was the initial implementation

Use cases

Screenshots

Logs

@v1v v1v added backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.9.0 Automated backport with mergify labels Aug 8, 2023
@v1v v1v requested a review from a team as a code owner August 8, 2023 07:06
@v1v v1v requested review from ycombinator and faec August 8, 2023 07:06
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 8, 2023
@mergify mergify bot assigned v1v Aug 8, 2023
@v1v v1v added the Team:Automation Label for the Observability productivity team label Aug 8, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 8, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 8, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-16T14:39:52.959+0000

  • Duration: 103 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 28120
Skipped 2015
Total 30135

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v
Copy link
Member Author

v1v commented Aug 16, 2023

@jlind23 @cmacknz , those users are the ones that will receive notifications regarding the Ironbank release process. You can include as many new maintainers as you wish.

I plan to merge this as soon as I get another approval.

@jlind23
Copy link
Collaborator

jlind23 commented Aug 16, 2023

@v1v Just added my information to make sure Nassim is not the only one being pinged.

@v1v v1v added the backport-v8.10.0 Automated backport with mergify label Aug 17, 2023
@v1v v1v merged commit ea8187c into elastic:main Aug 17, 2023
6 checks passed
@v1v v1v deleted the feature/update-ironbank-owners branch August 17, 2023 06:38
mergify bot pushed a commit that referenced this pull request Aug 17, 2023
mergify bot pushed a commit that referenced this pull request Aug 17, 2023
mergify bot pushed a commit that referenced this pull request Aug 17, 2023
v1v added a commit that referenced this pull request Aug 17, 2023
…36355)

(cherry picked from commit ea8187c)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit that referenced this pull request Aug 29, 2023
…36357)

(cherry picked from commit ea8187c)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.9.0 Automated backport with mergify backport-v8.10.0 Automated backport with mergify Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants