Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.12](backport #37788) aws - add credential caching for aws assume role sessions #37808

Merged
merged 2 commits into from
Jan 31, 2024
Merged

[8.12](backport #37788) aws - add credential caching for aws assume role sessions #37808

merged 2 commits into from
Jan 31, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 31, 2024 •
edited by zube bot
Loading

This is an automatic backport of pull request #37788 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@andrewkroh @mergify
aws - add credential caching for aws assume role sessions (#37788)
17958ee 
Add caching so that AWS `AssumeRole` session credentials are not requested for every single request. Sessions are valid for 15m by default but without caching that does not matter. This will speed up requests for users of `role_arn` by removing the overhead of most STS (session token service) calls and stop users from hitting rate-limiting issues with the STS.

Fixes #37787

(cherry picked from commit a6e5b04)
@mergify mergify bot requested a review from a team as a code owner January 31, 2024 17:08
@mergify mergify bot added the backport label Jan 31, 2024
@mergify mergify bot requested review from faec and leehinman and removed request for a team January 31, 2024 17:08
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 31, 2024
@botelastic
Copy link

botelastic bot commented Jan 31, 2024

This pull request doesn't have a Team:<team> label.

@andrewkroh andrewkroh enabled auto-merge (squash) January 31, 2024 17:14
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-01-31T17:14:12.638+0000

  • Duration: 124 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 8490
Skipped 381
Total 8871

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@andrewkroh andrewkroh merged commit b32a860 into 8.12 Jan 31, 2024
53 checks passed
@andrewkroh andrewkroh deleted the mergify/bp/8.12/pr-37788 branch January 31, 2024 19:18
@elasticmachine
Copy link
Collaborator

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2024-01-31T17:08:47.075+0000

  • Duration: 130 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 8490
Skipped 381
Total 8871

Steps errors 1

Expand to view the steps failures

Installing gotest.tools/gotestsum@latest
  • Took 0 min 8 sec . View more details here
  • Description: go install gotest.tools/gotestsum@latest

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@andrewkroh andrewkroh

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elasticmachine @andrewkroh