Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic when more than 32767 pipeline clients are active #38556

Merged
merged 9 commits into from
Apr 12, 2024
Merged

Fix panic when more than 32767 pipeline clients are active #38556

merged 9 commits into from
Apr 12, 2024

Commits on Apr 12, 2024

  1. [WIP] Fix panic when more than 32767 clients are active

    @belimawr
    belimawr committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    c25aecf View commit details
    Browse the repository at this point in the history

  2. Refactor tests 

    Refactor tests so they do not depend on `client.closeRef`
    @belimawr
    belimawr committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a95a3e1 View commit details
    Browse the repository at this point in the history

  3. Remove all references to CloseRef and unused fields 

    Remove all references to CloseRef, including the ones that were
commented out.
    @belimawr
    belimawr committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2e4f4ea View commit details
    Browse the repository at this point in the history

  4. Fix failing tests 

    The pipeline client used in some tests could not have its Close method
called more than once, given the changes introduces in the previous
commits, some test scenarios called it more than once.

This is fixed by using a sync.Once in ChanClient.Close.
    @belimawr
    belimawr committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    5085fec View commit details
    Browse the repository at this point in the history

  5. Remove comments

    @belimawr
    belimawr committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    7dad6ba View commit details
    Browse the repository at this point in the history

  6. Improve test 

    Fix number of clients to close, add some comments and better name a
variable.
    @belimawr
    belimawr committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2695d91 View commit details
    Browse the repository at this point in the history

  7. Implement PR review suggestions

    @belimawr
    belimawr committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a9c1911 View commit details
    Browse the repository at this point in the history

  8. Add changelog entries

    @belimawr
    belimawr committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    85e42dd View commit details
    Browse the repository at this point in the history

  9. Fix after rebase

    @belimawr
    belimawr committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8852d45 View commit details
    Browse the repository at this point in the history