Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DEV flag to snapshot. prepare-release-manager.sh staging param #39217

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Added DEV flag to snapshot. prepare-release-manager.sh staging param #39217

merged 3 commits into from
Apr 26, 2024

Conversation

pazone
Copy link
Contributor

@pazone pazone commented Apr 25, 2024

Proposed commit message

Added DEV flag to snapshot builds. Specified the workflow for prepare-release-manager.sh

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@pazone pazone requested a review from a team as a code owner April 25, 2024 15:14
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 25, 2024
@botelastic
Copy link

botelastic bot commented Apr 25, 2024

This pull request doesn't have a Team:<team> label.

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 25, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @pazone? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@mergify mergify bot assigned pazone Apr 25, 2024
alexsapran
alexsapran previously approved these changes Apr 25, 2024
View reviewed changes
@alexsapran alexsapran self-requested a review April 25, 2024 15:17
@alexsapran alexsapran dismissed their stale review April 25, 2024 15:18

follow up work is needed

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 25, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 13 min 40 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

dliappis
dliappis requested changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I am asking for a minor change for the sake consistency

.buildkite/packaging.pipeline.yml Show resolved Hide resolved
dliappis
dliappis approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dliappis dliappis merged commit 5687162 into main Apr 26, 2024
12 checks passed
@dliappis dliappis deleted the dra_minor_fixes branch April 26, 2024 09:24
pazone added a commit that referenced this pull request Apr 26, 2024
@pazone
Added DEV flag to snapshot. prepare-release-manager.sh staging param (#…
3e10895 
…39217)

Added DEV flag to snapshot builds. Specified the workflow for prepare-release-manager.sh

Relates: elastic/ingest-dev#3095
pazone added a commit that referenced this pull request Apr 26, 2024
@pazone
Added DEV flag to snapshot. prepare-release-manager.sh staging param (#…
4597106 
…39217)

Added DEV flag to snapshot builds. Specified the workflow for prepare-release-manager.sh

Relates: elastic/ingest-dev#3095
pazone added a commit that referenced this pull request Apr 26, 2024
@pazone
Added DEV flag to snapshot. prepare-release-manager.sh staging param (#…
d67ccbf 
…39217)

Added DEV flag to snapshot builds. Specified the workflow for prepare-release-manager.sh

Relates: elastic/ingest-dev#3095
pazone added a commit that referenced this pull request Apr 30, 2024
@mergify @pazone
@dliappis @alexsapran
[8.14](backport #39126) Beats DRA pipeline (#39199)
1ad2d38 
* Beats DRA pipeline (#39126)

* Packaging pipieline resource

* Revetred agentbeat pipeline deletion

* Cleanup

* Test auditbeat packaging pipeline

* Fix steps keys

* Fix steps keys

* Fix env vars

* Fix env vars

* Fix env vars

* Unified artifacts dir

* Implemented DRA steps

* Test filebeat

* Test matrix

* Aligned artifacts directories

* Aligned artifacts directories

* Aligned artifacts directories

* Aligned artifacts directories

* Debug

* Debug

* Package all beats

* Test DRA snapshot

* Test DRA snapshot

* Rename artifacts

* fix dashboards artifacts

* Cleanup

* cleanup

* No need to install msi tools

* Apply suggestions from code review

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>

* Extraced platforms variables

* Cleanup

* Added RUN_SNAPSHOT condition

* Cleanup

* Boolean dry-run

* Boolean dry-run

---------

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
(cherry picked from commit c6444db)

# Conflicts:
#	.buildkite/packaging.pipeline.yml

* Fixes for Buildkite packaging pipeline (#39207)

This PR fixes a number of bugs from #39126

* Fix BK DRA pipeline (#39212)

This commit fixes the error
"interpolating remaining fields: Expected identifier to start with a letter, got /"

* Fix permissions for packaging (#39218)

This commit fixes the release-manager error

> # > java.io.FileNotFoundException: /artifacts/build/distributions/... (Permission denied)

by adjusting the permissions of parent directories.
Additionally there are a few logging enhancements to improve debugging, as well as the introduction
of a new optional `DRA_BRANCH` environment variable, to help running and debugging via PRs.

Relates https://github.com/elastic/ingest-dev/issues/3095

---------

Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>

* Added DEV flag to snapshot. prepare-release-manager.sh staging param (#39217)

Added DEV flag to snapshot builds. Specified the workflow for prepare-release-manager.sh

Relates: https://github.com/elastic/ingest-dev/issues/3095

---------

Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
Co-authored-by: Alexandros Sapranidis <alexandros@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@alexsapran alexsapran Awaiting requested review from alexsapran

Assignees

@pazone pazone

Labels
enhancement needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pazone @elasticmachine @dliappis @alexsapran