-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-s3
input: Split S3 poller and SQS reader into explicit input objects
#39353
Merged
Merged
Changes from all commits
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
a4019ec
cleanup
faec a3d3757
cleanups
faec 597e0a5
break input sources up into separate helper functions
faec 0df748a
finish helper function split
faec 4b70900
rewrite the sqsReader main loop
faec 90d9e24
simplify sqsReader loop
faec 5f94e9b
adjust variable names
faec b797261
remove unused parameter
faec 88f3980
createS3Lister -> createS3Poller
faec 9f32df6
remove unused error checks
faec 48ec82a
cleanup
faec 58e084a
make a wrapper for v2.Canceler that doesn't use an extra goroutine
faec 1974f8f
remove unused parameter
faec 646374c
cleanup
faec a43cae6
remove redundant helper
faec f46ef06
adjust variable names
faec d9be04b
remove extra index indirection in state lookup
faec 5e1fbcc
remove redundant sync.Map
faec c16a22f
merge redundant state maps
faec f07915a
remove redundant state map
faec 0f483a3
simplify s3Poller worker handling
faec 8916d91
Merge branch 'main' of github.com:elastic/beats into awss3-cleanup
faec a8cb6bd
simplify waitgroup handling / unused errors
faec 78a7db4
clean up context handling
faec edc1bd3
adjust delay timer
faec 1497be4
remove unused struct fields
faec a3e0dc8
cleanup
faec 219e857
Refactor cloudwatch worker task allocation
faec 977a0d3
add unit tests for cloudwatchPoller.receive
faec 71134f9
Merge branch 'main' of github.com:elastic/beats into cloudwatch-fix
faec 6cf5506
update changelog
faec ff24571
make check
faec 5ec8a86
Merge branch 'cloudwatch-fix' into awss3-cleanup
faec 2a6abb8
Remove unused custom semaphore helper
faec 12a2a3c
cleanups in input.go
faec dd29fa0
revert unintentional return value change
faec 4956db9
Concurrency / error handling fixes in awss3
faec fc641e1
give the registry accessor its own mutex
faec 4a9cb60
update tests
faec 959d557
Merge branch 'main' of github.com:elastic/beats into s3-concurrency-fix
faec 3d93d22
make check
faec 7d6369f
lint
faec b4b5b28
lint
faec 45619e3
Merge branch 'main' of github.com:elastic/beats into s3-concurrency-fix
faec e88be00
Merge branch 's3-concurrency-fix' of github.com:faec/beats into awss3…
faec 1308a2d
Merge branch 'main' into s3-concurrency-fix
faec 0abf663
Merge branch 's3-concurrency-fix' into awss3-cleanup
faec 942ae03
cleaning up context use
faec e84471b
Merge branch 'main' into s3input-cleanup
faec 0289604
Merge branch 's3input-cleanup' into awss3-cleanup
faec 2c084bb
splitting S3 and SQS into distinct inputs internally
faec dbe4691
splitting awss3 into two input objects
faec 73d1465
Merge branch 'main' of github.com:elastic/beats into s3input-cleanup
faec ad7d342
Merge branch 's3input-cleanup' into awss3-cleanup
faec e05c45d
reorganize {s3,sqs}.go by adding {s3,sqs}_input.go for the code speci…
faec 54f0a87
clean up sqs helpers
faec 122ee8c
Merge branch 'main' into awss3-cleanup
faec d396457
fix merge
faec be54ac7
update tests
faec 568d2b0
merge sqsReaderInput and sqsReader
faec 383c111
get tests building again
faec 4b2ea11
remove redundant fields
faec de36816
more reorganization
faec 3117334
organizing
faec 6b43ac5
reordering code
faec d38af54
Merge branch 'main' of github.com:elastic/beats into awss3-cleanup
faec 3712af4
clean up states initialization
faec 894ba4c
remove unused helper
faec 31f3b95
working on test updates
faec 7d12f0a
fix benchmark tests
faec f1b7761
updating unit tests
faec fa22239
fix remaining tests
faec e253681
remove unused debug parameter
faec 5b922df
Merge branch 'main' of github.com:elastic/beats into awss3-cleanup
faec 1fef199
remove commented code
faec 800fc73
move helper function
faec 1694f0d
clean up aws client config modifiers
faec 63be523
reorder helper functions
faec 1bae757
reorder helper functions
faec 939c38f
update comments
faec b032106
move log creation earlier
faec 0995921
update comments
faec 5d9f731
make check
faec 3f152f4
starting unit tests
faec a722f68
update log initialization
faec 9e06e1e
Merge branch 'main' of github.com:elastic/beats into awss3-cleanup
faec 9cc8e7c
add comments
faec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea.