-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filebeat/module/apache: Rename the field apache2.module.error
to apache.module.error
#39481
Conversation
This pull request doesn't have a |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Nice find. Can you also open a PR for the integrations repo? See: https://github.com/search?q=repo%3Aelastic%2Fintegrations+path%3A%2F%5Epackages%5C%2Fapache%5C%2Fkibana%5C%2F%2F+apache2&type=code |
apache2.module.error
to apache.module.error
Please add an entry to the changelog. |
Thank you. I think I addressed both points now :) . I am on it for the integration's PR |
Changes LGTM. However, I would like another member of my team to review this as well before we merge. |
apache2.module.error
to apache.module.error
apache2.module.error
to apache.module.error
Co-authored-by: subham sarkar <subham.sarkar@elastic.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I see some failures in the build, but I hardly believe they are related with the change introduced here: |
@herrBez CI is passing. Let's merge? |
Done. Thank you for the help and support! |
Proposed commit message
Rename field apache2.module.error to apache.module.error in the Dashboard
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
None
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
The original saved search uses apache2.error.module, while the correct field apache.error.module (added by me) shows that it is actually populated with a meaningful value.
Logs