Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage AWS SDK(s) version with Dependabot #39738

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Manage AWS SDK(s) version with Dependabot #39738

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58bf3e7
Add github.com/aws/aws-sdk-go-v2/*
zmoog May 27, 2024
216a477
Add the AWS SDK to the dependencies allow list
zmoog Jul 25, 2024
326abe6
Add more AWS-related dependencies
zmoog Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ updates:
- dependency-name: github.com/elastic/toutoumomoma
- dependency-name: github.com/elastic/ebpfevents
# Team:Team:obs-ds-hosted-services, Team:obs-infraobs-integrations
# AWS SDK dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/*
# Azure SDK dependencies
- dependency-name: github.com/Azure/azure-sdk-for-go/*
- dependency-name: github.com/Azure/azure-event-hubs-go/*
Expand All @@ -45,6 +47,9 @@ updates:
- dependency-name: cloud.google.com/go/*
groups:
# Cloud providers' SDK dependencies
aws-sdks:
patterns:
- "github.com/aws/aws-sdk-go-v2/*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add github.com/aws/aws-lambda-go, github.com/aws/smithy-go and similar libs ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it makes sense! I created separate PRs to facilitate this kind of conversation.

Do we want to group these libraries in the AWS SDK (also adding to groups.aws-sdks.patterns), or is it better to keep them separate (by only including them in the allows list)?

We grouped all the AWS SDK in a group with the github.com/aws/aws-sdk-go-v2/* pattern to avoid dependencies problems like #39454 (a PR accidentally upgraded only the core library, breaking main).

Copy link
Contributor Author

@zmoog zmoog Jul 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding github.com/aws/aws-lambda-go and github.com/aws/smithy-go as dependencies to check if we are unsure. We can still add them later to the group.

azure-sdks:
patterns:
- "github.com/Azure/azure-*-go"
Expand Down
Loading