Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit config reload topics #4009

Merged
merged 1 commit into from
Apr 18, 2017
Merged

Conversation

dedemorton
Copy link
Contributor

@ruflin or @urso Probably one of you should review these changes. I thought about using a shared file with variables for this content, which is possible, but gets kind of messy, so I decided to use the copy/paste reuse approach. :-)

This resolves some of the edits from my editing backlog (tracked in #3539).

This needs to be backported to 5.3.

@dedemorton dedemorton added docs needs_backport PR is waiting to be backported to other branches. review labels Apr 12, 2017
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As soon as we also have heartbeat based on this model, we can check if working with variables makes sense.

@ruflin ruflin merged commit 6977885 into elastic:master Apr 18, 2017
dedemorton added a commit that referenced this pull request Apr 21, 2017
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label May 6, 2017
@pchila pchila mentioned this pull request Jul 23, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants