Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go-based changeset definition for MODULE #40238

Merged
merged 18 commits into from
Sep 23, 2024
Merged

Go-based changeset definition for MODULE #40238

merged 18 commits into from
Sep 23, 2024
+221 −127

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Jul 15, 2024 •
edited
Loading

Proposed commit message

Added MODULE env var definition within mage.
MODULE is set within invoking mage target, if there are changes brought by the PR, instead of calling separate bash-script to evaluate changes and define variable.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Logs

BK builds:

@oakrizan oakrizan added ci aws Enable builds in the CI for aws cloud testing backport-7.17 Automated backport to the 7.17 branch with mergify Team:Ingest-EngProd backport-v8.14.0 Automated backport with mergify backport-8.15 Automated backport to the 8.15 branch with mergify labels Jul 15, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 15, 2024
@oakrizan oakrizan force-pushed the mage-module-definition branch 8 times, most recently from 25988e6 to bdc7f7e Compare July 19, 2024 09:45
@oakrizan oakrizan removed the backport-7.17 Automated backport to the 7.17 branch with mergify label Jul 19, 2024
@oakrizan oakrizan force-pushed the mage-module-definition branch 7 times, most recently from 08c5048 to 4574030 Compare July 22, 2024 09:30
@oakrizan oakrizan removed the aws Enable builds in the CI for aws cloud testing label Jul 22, 2024
@oakrizan
Copy link
Contributor Author

/test

alexsapran
alexsapran reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@alexsapran alexsapran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, looking nice!

dev-tools/mage/module_changeset.go Show resolved Hide resolved
dev-tools/mage/module_changeset.go Outdated Show resolved Hide resolved
dev-tools/mage/module_changeset.go Outdated Show resolved Hide resolved
dev-tools/mage/module_changeset.go Outdated Show resolved Hide resolved
dev-tools/mage/module_changeset.go Outdated Show resolved Hide resolved
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 10, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 11, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@v1v v1v removed the backport-v8.x label Sep 11, 2024
alexsapran
alexsapran reviewed Sep 12, 2024
View reviewed changes
dev-tools/mage/module_changeset.go Outdated Show resolved Hide resolved
dev-tools/mage/module_changeset.go Outdated Show resolved Hide resolved
dev-tools/mage/module_changeset.go Outdated Show resolved Hide resolved
@oakrizan oakrizan requested a review from a team as a code owner September 19, 2024 14:19
@oakrizan oakrizan merged commit cc0bda7 into elastic:main Sep 23, 2024
171 checks passed
mergify bot pushed a commit that referenced this pull request Sep 23, 2024
@oakrizan @mergify
Go-based changeset definition for MODULE (#40238)
54f3296 
Added MODULE env var definition within mage

(cherry picked from commit cc0bda7)

# Conflicts:
#	.buildkite/heartbeat/heartbeat-pipeline.yml
#	.buildkite/x-pack/pipeline.xpack.auditbeat.yml
#	.buildkite/x-pack/pipeline.xpack.dockerlogbeat.yml
#	.buildkite/x-pack/pipeline.xpack.metricbeat.yml
#	.buildkite/x-pack/pipeline.xpack.winlogbeat.yml
#	x-pack/auditbeat/magefile.go
mergify bot pushed a commit that referenced this pull request Sep 23, 2024
@oakrizan @mergify
Go-based changeset definition for MODULE (#40238)
82388d3 
Added MODULE env var definition within mage

(cherry picked from commit cc0bda7)
This was referenced Sep 23, 2024
Open
Open
mergify bot pushed a commit that referenced this pull request Sep 23, 2024
@oakrizan @mergify
Go-based changeset definition for MODULE (#40238)
1786766 
Added MODULE env var definition within mage

(cherry picked from commit cc0bda7)
@mergify mergify bot mentioned this pull request Sep 23, 2024
Open
6 tasks
mergify bot pushed a commit that referenced this pull request Sep 23, 2024
@oakrizan @mergify
Go-based changeset definition for MODULE (#40238)
b2c3eb4 
Added MODULE env var definition within mage

(cherry picked from commit cc0bda7)
@mergify mergify bot mentioned this pull request Sep 23, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belimawr belimawr belimawr approved these changes

@alexsapran alexsapran alexsapran approved these changes

@pazone pazone pazone approved these changes

@nfritts nfritts nfritts approved these changes

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

@dliappis dliappis Awaiting requested review from dliappis

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry

@pkoutsovasilis pkoutsovasilis Awaiting requested review from pkoutsovasilis

Assignees

@oakrizan oakrizan

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify backport-v8.14.0 Automated backport with mergify ci Team:Ingest-EngProd :Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oakrizan @belimawr @alexsapran @pazone @nfritts @v1v