x-pack/filebeat/i.../entitya.../.../okta: Avoid a negative request rate #40267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisberkhout
added
bugfix
Team:Security-Service Integrations
botelastic
bot
added
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
chrisberkhout
added
backport-v8.14.0
|
Are those release labels correct? |
efd6
approved these changes
Jul 16, 2024
chrisberkhout
force-pushed
the
okta-ea-ratelimit-minimal-fix
branch
from
07d3de2 to
22994a7
Compare
chrisberkhout
force-pushed
the
okta-ea-ratelimit-minimal-fix
branch
from
22994a7 to
ab4a31e
Compare
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
mergify bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
…te (#40267) This is the minimal change necessary to fix the following problem. Around the time of a rate limit reset, if current time is after the reset time returned in response headers, the rate limiting code will set a negative target rate, and if that's done at a time when no request budget has accumulated, it will not recover and will wait forever. (cherry picked from commit 5087dd4)
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
…te (#40267) This is the minimal change necessary to fix the following problem. Around the time of a rate limit reset, if current time is after the reset time returned in response headers, the rate limiting code will set a negative target rate, and if that's done at a time when no request budget has accumulated, it will not recover and will wait forever. (cherry picked from commit 5087dd4)
6 tasks
chrisberkhout
pushed a commit
that referenced
this pull request
Aug 8, 2024
…te (#40267) (#40460) This is the minimal change necessary to fix the following problem. Around the time of a rate limit reset, if current time is after the reset time returned in response headers, the rate limiting code will set a negative target rate, and if that's done at a time when no request budget has accumulated, it will not recover and will wait forever.
chrisberkhout
pushed a commit
that referenced
this pull request
Aug 8, 2024
…id a negative request rate (#40459) This is the minimal change necessary to fix the following problem. Around the time of a rate limit reset, if current time is after the reset time returned in response headers, the rate limiting code will set a negative target rate, and if that's done at a time when no request budget has accumulated, it will not recover and will wait forever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The issue linked below lists other fixes and improvements that could be made the the Okta entity analytics rate limiting code. This PR is a version that should go into the next release to relieve the impact if the other changes aren't ready yet.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues