Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing return statement #4045

Merged
merged 2 commits into from
Apr 20, 2017
Merged

add missing return statement #4045

merged 2 commits into from
Apr 20, 2017

Conversation

glefloch
Copy link
Contributor

Add missing return statement

Close #4041

@karmi
Copy link

karmi commented Apr 19, 2017

Hi @glefloch, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@elasticmachine
Copy link
Collaborator

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

1 similar comment
@elasticmachine
Copy link
Collaborator

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

@glefloch
Copy link
Contributor Author

Yes I'm gonna do that

@ruflin ruflin added bug libbeat needs_backport PR is waiting to be backported to other branches. review labels Apr 19, 2017
@monicasarbu
Copy link
Contributor

@glefloch Thanks for the PR. Waiting for the CLA check to be green.

@glefloch
Copy link
Contributor Author

I already signed it... It was green before my last commit. Is that normal that it's not?

@ruflin
Copy link
Member

ruflin commented Apr 19, 2017

I think there is currently an issue with the CLA checker on all PRs ...

@monicasarbu monicasarbu merged commit 18525be into elastic:master Apr 20, 2017
ruflin pushed a commit to ruflin/beats that referenced this pull request Apr 27, 2017
* fix missing return

(cherry picked from commit 18525be)
ruflin pushed a commit to ruflin/beats that referenced this pull request Apr 27, 2017
* fix missing return

(cherry picked from commit 18525be)
ruflin pushed a commit to ruflin/beats that referenced this pull request Apr 27, 2017
* fix missing return

(cherry picked from commit 18525be)
tsg pushed a commit that referenced this pull request Apr 28, 2017
* fix missing return

(cherry picked from commit 18525be)
tsg pushed a commit that referenced this pull request Apr 28, 2017
* fix missing return

(cherry picked from commit 18525be)
@ruflin ruflin removed the needs_backport PR is waiting to be backported to other branches. label May 8, 2017
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
* fix missing return

(cherry picked from commit 74d14d3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants