[vSphere] Add new Cluster metricset #40536

niraj-elastic · 2024-08-15T14:12:51Z

Enhancement

Description

Added following new metrics for the datastore metricset in the vSphere metricbeat module. added new performance API to get more detailed info from the vSphere.

Metrics Type	Metrics	Field Mappings
Cluster Summry
	ClusterComputeResource.Host	cluster.host_names
	ClusterComputeResource.Datastore	cluster.datastore_names
	ClusterComputeResource.Network	cluster.network_names
	ClusterComputeResource.Configuration.DasConfig.Enabled	cluster.das_config.enabled
	ClusterComputeResource.Configuration.DasConfig.AdmissionControlEnabled	cluster.das_config.admission.control.enabled

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Relates https://github.com/elastic/obs-integration-team/issues/23

mergify · 2024-08-15T14:13:33Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @niraj-elastic? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

elasticmachine · 2024-08-19T13:33:37Z

Pinging @elastic/integrations (Team:Integrations)

mergify · 2024-08-22T09:54:02Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b vsphere_cluster_metricset upstream/vsphere_cluster_metricset
git merge upstream/main
git push upstream vsphere_cluster_metricset

ishleenk17 · 2024-08-28T07:10:00Z

metricbeat/module/vsphere/cluster/cluster.go

+type assetNames struct {
+	outputNtNames []string
+	outputDsNames []string
+	outputHsNames []string


Aren't VM's part of the cluster as well ?

We have included all the available list, VMs are not available in object.

If customer wants to get the VM info they can then refer to the details of the hosts and the VM associated with it (through the host metricset).

…phere_cluster_metricset Conflicts: metricbeat/docs/modules/vsphere.asciidoc metricbeat/metricbeat.reference.yml metricbeat/module/vsphere/_meta/config.reference.yml metricbeat/module/vsphere/fields.go

metricbeat/module/vsphere/cluster/cluster.go

metricbeat/module/vsphere/datastore/data.go

…elastic/beats into vsphere_cluster_metricset

mergify · 2024-08-29T15:50:44Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b vsphere_cluster_metricset upstream/vsphere_cluster_metricset
git merge upstream/main
git push upstream vsphere_cluster_metricset

…phere_cluster_metricset

mergify · 2024-08-29T17:43:59Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b vsphere_cluster_metricset upstream/vsphere_cluster_metricset
git merge upstream/main
git push upstream vsphere_cluster_metricset

…phere_cluster_metricset Conflicts: metricbeat/docs/modules/vsphere.asciidoc metricbeat/docs/modules_list.asciidoc metricbeat/metricbeat.reference.yml metricbeat/module/vsphere/_meta/config.reference.yml metricbeat/module/vsphere/_meta/docs.asciidoc metricbeat/module/vsphere/fields.go x-pack/metricbeat/metricbeat.reference.yml

metricbeat/module/vsphere/cluster/_meta/fields.yml

ishleenk17 · 2024-08-29T13:00:45Z

metricbeat/module/vsphere/cluster/cluster.go

+type assetNames struct {
+	outputNtNames []string
+	outputDsNames []string
+	outputHsNames []string


If customer wants to get the VM info they can then refer to the details of the hosts and the VM associated with it (through the host metricset).

kush-elastic

LGTM

* add cluster metricset * update changelog * fix lint errors * minor changes * add unit test * update fields.yml * mage update * minor changes * minor changes * mage update * Address review comment * Address review comments * address review comments * update data.json * update fields.yml * update data.json * lint changes * mage update * mage update for x-pack * Mage update after conflicts * update fields.go * Address review comments --------- Co-authored-by: Niraj Rathod <niraj.rathod@crestdatasys.com> Co-authored-by: subham sarkar <subham.sarkar@elastic.co> (cherry picked from commit 1058457) # Conflicts: # metricbeat/docs/modules/vsphere.asciidoc # metricbeat/docs/modules_list.asciidoc # metricbeat/metricbeat.reference.yml # metricbeat/module/vsphere/_meta/config.reference.yml # metricbeat/module/vsphere/_meta/docs.asciidoc # metricbeat/module/vsphere/datastore/_meta/data.json # metricbeat/module/vsphere/datastore/data.go # metricbeat/module/vsphere/datastore/data_test.go # metricbeat/module/vsphere/datastore/datastore.go # metricbeat/module/vsphere/datastore/datastore_test.go # metricbeat/module/vsphere/fields.go # x-pack/metricbeat/metricbeat.reference.yml

* add cluster metricset * update changelog * fix lint errors * minor changes * add unit test * update fields.yml * mage update * minor changes * minor changes * mage update * Address review comment * Address review comments * address review comments * update data.json * update fields.yml * update data.json * lint changes * mage update * mage update for x-pack * Mage update after conflicts * update fields.go * Address review comments --------- Co-authored-by: Niraj Rathod <niraj.rathod@crestdatasys.com> Co-authored-by: subham sarkar <subham.sarkar@elastic.co>

…ckport (#40828) * [vSphere] Add new Cluster metricset (#40536) * add cluster metricset * update changelog * fix lint errors * minor changes * add unit test * update fields.yml * mage update * minor changes * minor changes * mage update * Address review comment * Address review comments * address review comments * update data.json * update fields.yml * update data.json * lint changes * mage update * mage update for x-pack * Mage update after conflicts * update fields.go * Address review comments --------- Co-authored-by: Niraj Rathod <niraj.rathod@crestdatasys.com> Co-authored-by: subham sarkar <subham.sarkar@elastic.co> * Update CHANGELOG.next.asciidoc * Update CHANGELOG.next.asciidoc * Update CHANGELOG.next.asciidoc --------- Co-authored-by: niraj-elastic <124254029+niraj-elastic@users.noreply.github.com> Co-authored-by: Niraj Rathod <niraj.rathod@crestdatasys.com> Co-authored-by: subham sarkar <subham.sarkar@elastic.co>

add cluster metricset

c1e34ec

niraj-elastic requested review from lalit-satapathy, kush-elastic, ishleenk17 and harnish-elastic August 15, 2024 14:12

niraj-elastic self-assigned this Aug 15, 2024

niraj-elastic requested a review from a team as a code owner August 15, 2024 14:12

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 15, 2024

niraj-crest added 2 commits August 15, 2024 19:45

update changelog

2ffae91

fix lint errors

5009309

lalit-satapathy added the Team:Integrations Label for the Integrations team label Aug 19, 2024

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 19, 2024

niraj-crest added 4 commits August 27, 2024 11:18

minor changes

895c19d

add unit test

7e3982d

update fields.yml

58c2ff6

mage update

3173898

niraj-elastic requested a review from a team as a code owner August 27, 2024 10:31

niraj-elastic requested review from AndersonQ and VihasMakwana August 27, 2024 10:31

minor changes

6c94fce

ishleenk17 reviewed Aug 28, 2024

View reviewed changes

niraj-crest added 3 commits August 28, 2024 13:17

minor changes

7289c01

mage update

b10f6e8

niraj-elastic requested a review from ishleenk17 August 28, 2024 09:04

kush-elastic reviewed Aug 28, 2024

View reviewed changes

metricbeat/module/vsphere/cluster/cluster.go Outdated Show resolved Hide resolved

kush-elastic reviewed Aug 28, 2024

View reviewed changes

metricbeat/module/vsphere/datastore/data.go Outdated Show resolved Hide resolved

Merge branch 'main' into vsphere_cluster_metricset

bcf98c8

shmsr approved these changes Aug 29, 2024

View reviewed changes

niraj-crest added 2 commits August 29, 2024 16:52

lint changes

7a2ed26

Merge branch 'vsphere_cluster_metricset' of https://github.com/niraj-…

cc90c76

…elastic/beats into vsphere_cluster_metricset

niraj-elastic requested a review from AndersonQ August 29, 2024 11:27

Merge branch 'main' into vsphere_cluster_metricset

5a84640

niraj-crest added 3 commits August 29, 2024 22:21

mage update

4c17b58

Merge branch 'main' of https://github.com/niraj-elastic/beats into vs…

2381255

…phere_cluster_metricset

mage update for x-pack

5b44f90

niraj-crest added 3 commits August 29, 2024 23:32

Mage update after conflicts

c1fa02d

update fields.go

89e76da

ishleenk17 approved these changes Aug 30, 2024

View reviewed changes

Address review comments

91cea3d

kush-elastic approved these changes Aug 30, 2024

View reviewed changes

AndersonQ approved these changes Aug 30, 2024

View reviewed changes

niraj-elastic merged commit 1058457 into elastic:main Aug 31, 2024
29 checks passed

niraj-elastic added backport-8.x Automated backport to the 8.x branch with mergify and removed backport-8.x Automated backport to the 8.x branch with mergify labels Sep 10, 2024

ishleenk17 added backport-8.15 Automated backport to the 8.15 branch with mergify and removed Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Sep 12, 2024

mergify bot mentioned this pull request Sep 12, 2024

[8.15](backport #40536) [vSphere] Add new Cluster metricset #40790

Closed

6 tasks

ishleenk17 mentioned this pull request Sep 14, 2024

[8.15](backport #40536) [vSphere] Add new Cluster metricset #40826

Closed

6 tasks

ishleenk17 mentioned this pull request Sep 14, 2024

[8.15](backport #40536) [vSphere] Add new Cluster metricset manual backport #40828

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vSphere] Add new Cluster metricset #40536

[vSphere] Add new Cluster metricset #40536

niraj-elastic commented Aug 15, 2024

mergify bot commented Aug 15, 2024

elasticmachine commented Aug 19, 2024

mergify bot commented Aug 22, 2024

ishleenk17 Aug 28, 2024

niraj-elastic Aug 28, 2024

ishleenk17 Aug 29, 2024

mergify bot commented Aug 29, 2024

mergify bot commented Aug 29, 2024

ishleenk17 Aug 29, 2024

kush-elastic left a comment

[vSphere] Add new Cluster metricset #40536

[vSphere] Add new Cluster metricset #40536

Conversation

niraj-elastic commented Aug 15, 2024

Description

Checklist

Related issues

mergify bot commented Aug 15, 2024

elasticmachine commented Aug 19, 2024

mergify bot commented Aug 22, 2024

ishleenk17 Aug 28, 2024

Choose a reason for hiding this comment

niraj-elastic Aug 28, 2024

Choose a reason for hiding this comment

ishleenk17 Aug 29, 2024

Choose a reason for hiding this comment

mergify bot commented Aug 29, 2024

mergify bot commented Aug 29, 2024

ishleenk17 Aug 29, 2024

Choose a reason for hiding this comment

kush-elastic left a comment

Choose a reason for hiding this comment