Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updatecli: bump ironbank UBI #40633

Merged
merged 10 commits into from
Sep 11, 2024
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Aug 27, 2024

What does this PR do?

Enable updatecli policies to bump the Ironbank versions automatically, then #39988 and #40469 won't be manually created.

Those policies can be found at https://github.com/elastic/oblt-updatecli-policies/tree/main/updatecli/policies/ (NOTE: This is a private repository only accessible by Elastic employees)

Additional changes

  • Refactor the updatecli pipelines to use the values.d/scm.yml file.
  • Change files to a different location

Why is it important?

One less thing to be worried about.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

  1. gh pr checkout 40633
  2. Install updatecli
  3. Login to ghcr.io
  4. Diff (dry-run)
$ GITHUB_TOKEN=$(gh auth token) updatecli compose diff --experimental
  1. Create Pull Request if new changes
$ GITHUB_REPOSITORY=elastic/beats \
   GITHUB_ACTOR=v1v \
   GITHUB_TOKEN=$(gh auth token) \
updatecli compose apply --experimental

Related issues

See elastic/apm-server#13934

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 27, 2024
@mergify mergify bot assigned v1v Aug 27, 2024
Copy link
Contributor

mergify bot commented Aug 27, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @v1v? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

.github/workflows/updatecli.d/values.d/ironbank.yml Outdated Show resolved Hide resolved
updatecli-compose.yaml Outdated Show resolved Hide resolved
@v1v v1v marked this pull request as ready for review August 28, 2024 15:55
@v1v v1v requested review from a team as code owners August 28, 2024 15:55
@v1v v1v requested review from faec and VihasMakwana August 28, 2024 15:55
@v1v v1v requested a review from a team August 28, 2024 15:55
@v1v v1v added backport-7.17 Automated backport to the 7.17 branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify labels Aug 28, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Aug 28, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

.github/workflows/updatecli.d/values.d/scm.yml Outdated Show resolved Hide resolved
updatecli-compose.yaml Outdated Show resolved Hide resolved
@v1v v1v enabled auto-merge (squash) September 4, 2024 14:17
Copy link
Contributor

mergify bot commented Sep 11, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@v1v v1v removed the backport-v8.x label Sep 11, 2024
@v1v v1v merged commit 54f3d9e into elastic:main Sep 11, 2024
9 checks passed
mergify bot pushed a commit that referenced this pull request Sep 11, 2024
mergify bot pushed a commit that referenced this pull request Sep 11, 2024
mergify bot pushed a commit that referenced this pull request Sep 11, 2024
v1v added a commit that referenced this pull request Sep 11, 2024
(cherry picked from commit 54f3d9e)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit that referenced this pull request Sep 11, 2024
(cherry picked from commit 54f3d9e)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants