Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change maintainer label to opencontainers in Dockerfile #40736

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

mauri870
Copy link
Member

Proposed commit message

The old way of specifying maintainers in a Dockerfile was to use the MAINTAINER instruction. This is now deprecated and the maintainer label was used instead.

Nowadays the recommended way to set a maintainer is through the org.opencontainers.image.authors label.

See https://docs.docker.com/reference/build-checks/maintainer-deprecated/.

Author's Checklist

  • I wonder if we look for a maintainer label in the images somewhere, if that is the case this can be a breaking change.

The old way of specifying maintainers in a Dockerfile was to use the
MAINTAINER instruction. This is now deprecated and the maintainer label was
used instead.

Nowadays the recommended way to set a maintainer is through the
`org.opencontainers.image.authors` label.

See https://docs.docker.com/reference/build-checks/maintainer-deprecated/.
@mauri870 mauri870 added cleanup backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Sep 10, 2024
@mauri870 mauri870 requested a review from a team as a code owner September 10, 2024 14:41
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 10, 2024
Copy link
Contributor

mergify bot commented Sep 10, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.

@v1v v1v removed the backport-skip Skip notification from the automated backport with mergify label Sep 10, 2024
Copy link
Contributor

mergify bot commented Sep 11, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@v1v v1v removed the backport-v8.x label Sep 11, 2024
@leehinman
Copy link
Contributor

Probably needs to happen in the elastic-agent repo as well.

@mauri870
Copy link
Member Author

Probably needs to happen in the elastic-agent repo as well.

Thanks, I'll make sure to check the agent as well!

@mauri870 mauri870 merged commit 4cc11f2 into elastic:main Sep 11, 2024
125 checks passed
mergify bot pushed a commit that referenced this pull request Sep 11, 2024
The old way of specifying maintainers in a Dockerfile was to use the
MAINTAINER instruction. This is now deprecated and the maintainer label was
used instead.

Nowadays the recommended way to set a maintainer is through the
`org.opencontainers.image.authors` label.

See https://docs.docker.com/reference/build-checks/maintainer-deprecated/.

(cherry picked from commit 4cc11f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants