-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong user for installing Synthetics #40747
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdner
added
bug
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
backport-8.x
Automated backport to the 8.x branch with mergify
labels
Sep 11, 2024
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Sep 11, 2024
|
The current user must be used instead of `root`.
rdner
force-pushed
the
fix-heartbeat-browser-monitor
branch
from
September 11, 2024 10:53
f4030ef
to
515f3dc
Compare
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
rdner
requested review from
emilioalvap and
belimawr
and removed request for
faec
September 11, 2024 14:57
leehinman
approved these changes
Sep 11, 2024
emilioalvap
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mergify bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
The current user must be used instead of `root`. (cherry picked from commit 7474918)
rdner
added a commit
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-8.x
Automated backport to the 8.x branch with mergify
bug
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current user must be used instead of
root
.How to test this PR locally
I copied the testing steps from #40689 and followed them.
cd ./x-pack/heartbeat PLATFORMS=linux/arm64 PACKAGES=docker mage package
heartbeat.docker.yml
):status: up
.Related issues