Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15](backport #40441) [vSphere][datastore] Add additional metrics #40782

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 12, 2024

Description

Added following new metrics for the datastore metricset in the vSphere metricbeat module. added new performance API to get more detailed info from the vSphere.

Metrics Type Metrics Field Mappings
Datastore performance  
datastore.read.average (KBps) datastore.read.bytes
datastore.write.average (KBps) datastore.write.bytes
datastore.datastoreIops.average (num) datastore.iops
datastore.totalReadLatency.average (ms) datastore.read.latency.total.ms
datastore.totalWriteLatency.average (ms) datastore.write.latency.total.ms
Datastore Summry  
Datastore.OverallStatus datastore.status
Datastore.Host datastore.host.count
Datastore.Host datastore.host.names
Datastore.Vm datastore.vm.count
Datastore.Vm datastore.vm.names

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues


This is an automatic backport of pull request #40441 done by [Mergify](https://mergify.com).

* add data collection

* update changelog

* update datacollection

* update fields.yml

* update test files

* update field discriptions

* address review comments

* address review comments

* address review commetns

* update fields

* update usint test

* address review comments

* update data_test file

* update unit test

* address review comments

* update fields.asci

* address review comments

* update data_test file

* update go.mod file

* update NOTICE.txt

* address review comment

* address review comments

* mage update

* address review comments

* Address review comments

---------

Co-authored-by: Niraj Rathod <niraj.rathod@crestdatasys.com>
(cherry picked from commit 94ca509)

# Conflicts:
#	metricbeat/module/vsphere/fields.go
@mergify mergify bot requested a review from a team as a code owner September 12, 2024 09:59
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Sep 12, 2024
Copy link
Contributor Author

mergify bot commented Sep 12, 2024

Cherry-pick of 94ca509 has failed:

On branch mergify/bp/8.15/pr-40441
Your branch is up to date with 'origin/8.15'.

You are currently cherry-picking commit 94ca5096f8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.next.asciidoc
	modified:   metricbeat/docs/fields.asciidoc
	modified:   metricbeat/module/vsphere/datastore/_meta/data.json
	modified:   metricbeat/module/vsphere/datastore/_meta/fields.yml
	new file:   metricbeat/module/vsphere/datastore/data.go
	new file:   metricbeat/module/vsphere/datastore/data_test.go
	modified:   metricbeat/module/vsphere/datastore/datastore.go
	modified:   metricbeat/module/vsphere/datastore/datastore_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   metricbeat/module/vsphere/fields.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 12, 2024
@botelastic
Copy link

botelastic bot commented Sep 12, 2024

This pull request doesn't have a Team:<team> label.

@ishleenk17
Copy link
Contributor

/test

Copy link
Contributor Author

mergify bot commented Sep 13, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.15/pr-40441 upstream/mergify/bp/8.15/pr-40441
git merge upstream/8.15
git push upstream mergify/bp/8.15/pr-40441

Copy link
Contributor

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM backport PR.

@ishleenk17 ishleenk17 merged commit ef04f1c into 8.15 Sep 13, 2024
29 checks passed
@ishleenk17 ishleenk17 deleted the mergify/bp/8.15/pr-40441 branch September 13, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants