Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x](backport #40918) x-pack/metricbeat/module/gcp: Override GCP API endpoint in metric client #40938

Merged
merged 2 commits into from
Sep 23, 2024
Merged

[8.x](backport #40918) x-pack/metricbeat/module/gcp: Override GCP API endpoint in metric client #40938

merged 2 commits into from
Sep 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 21, 2024 •
edited by zube bot
Loading

Proposed commit message

The GCP metric client does not currently allow overriding with a custom endpoint, which is necessary for testing against a mock GCP API endpoint.
Resolved this issue by implementing a check to determine if an endpoint is specified in the GCP configuration, and subsequently overriding the ClientOption with that endpoint.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

This is an automatic backport of pull request #40918 done by [Mergify](https://mergify.com).

@Linu-Elias @mergify
x-pack/metricbeat/module/gcp: Override GCP API endpoint in metric cli…
2356d10 
…ent (#40918)

* override endpoint to etric client

* config and changelog

* doc

* resolved comments

* lint fix

(cherry picked from commit 7720c90)
@mergify mergify bot requested a review from a team as a code owner September 21, 2024 06:58
@mergify mergify bot added the backport label Sep 21, 2024
@mergify mergify bot requested review from a team as code owners September 21, 2024 06:58
@mergify mergify bot removed the request for review from a team September 21, 2024 06:58
@mergify mergify bot requested review from AndersonQ and khushijain21 September 21, 2024 06:58
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2024
@botelastic
Copy link

botelastic bot commented Sep 21, 2024

This pull request doesn't have a Team:<team> label.

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Sep 23, 2024

This pull request has not been merged yet. Could you please review and merge it @Linu-Elias? 🙏

@pierrehilbert pierrehilbert merged commit 6810f39 into 8.x Sep 23, 2024
29 checks passed
@pierrehilbert pierrehilbert deleted the mergify/bp/8.x/pr-40918 branch September 23, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-data-plane

@khushijain21 khushijain21 Awaiting requested review from khushijain21 khushijain21 is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@Linu-Elias Linu-Elias

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierrehilbert @Linu-Elias