Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x](backport #40924) [system/process]: mark module as healthy if metrics are partially filled for single process as well. #41169

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[8.x](backport #40924) [system/process]: mark module as healthy if metrics are partially filled for single process as well. #41169

merged 1 commit into from
Oct 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 8, 2024 •
edited by zube bot
Loading

  • Bug

This PR follows #40565. It does the same thing when a single pid is used in config.

Closes elastic/elastic-agent#5555

Testing steps:

  • Build agentbeat from this branch.
  • Place the agentbeat binary under elastic-agent/components
  • Run the elastic agent in unprivileged mode and enabled the system.process dataset for any privileged process.
  • You should see status as healthy.
This is an automatic backport of pull request #40924 done by [Mergify](https://mergify.com).

@VihasMakwana @mergify
[system/process]: mark module as healthy if metrics are partially fi…
3037165 
…lled for single process as well. (#40924)

* fix: mark module as healthy if metrics are partially filled for single processes

* chore: fix lint

* chore: wrap the error and return

* chore: fix lint

---------

Co-authored-by: subham sarkar <subham.sarkar@elastic.co>
(cherry picked from commit dc94114)
@mergify mergify bot requested a review from a team as a code owner October 8, 2024 07:31
@mergify mergify bot added the backport label Oct 8, 2024
@mergify mergify bot requested review from rdner and mauri870 and removed request for a team October 8, 2024 07:31
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 8, 2024
@botelastic
Copy link

botelastic bot commented Oct 8, 2024

This pull request doesn't have a Team:<team> label.

@pierrehilbert pierrehilbert enabled auto-merge (squash) October 8, 2024 07:32
@pierrehilbert pierrehilbert merged commit 591e713 into 8.x Oct 8, 2024
31 checks passed
@pierrehilbert pierrehilbert deleted the mergify/bp/8.x/pr-40924 branch October 8, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

@mauri870 mauri870 Awaiting requested review from mauri870 mauri870 is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@VihasMakwana VihasMakwana

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierrehilbert @VihasMakwana