Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/streaming: log websocket bad handshake details #41300

Merged
merged 1 commit into from
Oct 18, 2024
Merged

x-pack/filebeat/input/streaming: log websocket bad handshake details #41300

merged 1 commit into from
Oct 18, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Oct 18, 2024

Proposed commit message

See title.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added Filebeat Filebeat bugfix Team:Security-Service Integrations Security Service Integrations Team labels Oct 18, 2024
@efd6 efd6 self-assigned this Oct 18, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 18, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 18, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @efd6? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 18, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 18, 2024
@efd6 efd6 force-pushed the websocket_bad_handshake branch from 50e8046 to 97fd5a3 Compare October 18, 2024 06:02
@efd6 efd6 marked this pull request as ready for review October 18, 2024 07:46
@efd6 efd6 requested a review from a team as a code owner October 18, 2024 07:46
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 added backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.16 Automated backport with mergify labels Oct 18, 2024
@efd6 efd6 enabled auto-merge (squash) October 18, 2024 07:57
@efd6 efd6 merged commit 0c2f9e7 into elastic:main Oct 18, 2024
20 of 22 checks passed
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
@efd6 @mergify
x-pack/filebeat/input/streaming: log websocket bad handshake details (#…
482db84 
…41300)

(cherry picked from commit 0c2f9e7)

# Conflicts:
#	x-pack/filebeat/input/streaming/websocket.go
@mergify mergify bot mentioned this pull request Oct 18, 2024
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
@efd6 @mergify
x-pack/filebeat/input/streaming: log websocket bad handshake details (#…
4e566c3 
…41300)

(cherry picked from commit 0c2f9e7)
@mergify mergify bot mentioned this pull request Oct 18, 2024
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
@efd6 @mergify
x-pack/filebeat/input/streaming: log websocket bad handshake details (#…
3fc19a5 
…41300)

(cherry picked from commit 0c2f9e7)
@mergify mergify bot mentioned this pull request Oct 18, 2024
Merged
6 tasks
belimawr pushed a commit to belimawr/beats that referenced this pull request Oct 18, 2024
@efd6 @belimawr
x-pack/filebeat/input/streaming: log websocket bad handshake details (e…
fd28cb4 
…lastic#41300)
efd6 added a commit that referenced this pull request Oct 22, 2024
@efd6
x-pack/filebeat/input/websocket: log websocket bad handshake details (#…
ce335fa 
…41300)

(cherry picked from commit 0c2f9e7)
efd6 added a commit that referenced this pull request Oct 22, 2024
@mergify @efd6
x-pack/filebeat/input/streaming: log websocket bad handshake details (#…
7909b93 
…41300) (#41302)

(cherry picked from commit 0c2f9e7)

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
efd6 added a commit that referenced this pull request Oct 22, 2024
@efd6
x-pack/filebeat/input/websocket: log websocket bad handshake details (#…
54d7fa1 
…41300)

Manual cherrypick.

(cherry picked from commit 0c2f9e7)
efd6 added a commit that referenced this pull request Oct 23, 2024
@mergify @efd6
x-pack/filebeat/input/websocket: log websocket bad handshake details (#…
e2640ca 
…41300) (#41301)

Manual cherry pick.

(cherry picked from commit 0c2f9e7)

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
efd6 added a commit that referenced this pull request Oct 23, 2024
@efd6
x-pack/filebeat/input/streaming: log websocket bad handshake details (#…
2750ceb 
…41300)

(cherry picked from commit 0c2f9e7)
efd6 added a commit that referenced this pull request Oct 23, 2024
@mergify @efd6
x-pack/filebeat/input/streaming: log websocket bad handshake details (#…
44d1cdc 
…41300) (#41303)

(cherry picked from commit 0c2f9e7)

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShourieG ShourieG ShourieG approved these changes

Assignees

@efd6 efd6

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.16 Automated backport with mergify bugfix Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @ShourieG