-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-pack/filebeat/input/awss3: support for Access Point ARN #41495
x-pack/filebeat/input/awss3: support for Access Point ARN #41495
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
This pull request is now in conflicts. Could you fix it? 🙏
|
d3b8e50
to
827c92e
Compare
827c92e
to
148d6c6
Compare
c501329
to
dfb0fdb
Compare
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert in the AWS S3 input, but LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM, just make sure to do not merge the 8.16 backport until 8.16.1 is released. |
This pull request is now in conflicts. Could you fix it? 🙏
|
Looks good to me. Can we create an issue in the integrations repo to add this new parameter later in related data streams please? Thanks! |
Does setting the Access Point ARN work when using SQS? |
Thank you for the review. The issue for updating the integrations is elastic/integrations#11737. |
Added a new option access_point_arn to the AWS S3 input as an alternative to the bucket ARN to access S3 buckets. (cherry picked from commit 301988d)
Added a new option access_point_arn to the AWS S3 input as an alternative to the bucket ARN to access S3 buckets. (cherry picked from commit 301988d)
…s Point ARN (#41689) Added a new option access_point_arn to the AWS S3 input as an alternative to the bucket ARN to access S3 buckets.
Proposed commit message
Added a new option
access_point_arn
to the AWS S3 input as an alternative to the bucket ARN to access S3 buckets.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues