Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for region/zone for Vertex AI service in GCP module #41551

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

ishleenk17
Copy link
Contributor

@ishleenk17 ishleenk17 commented Nov 7, 2024

Checklist

  • [ x ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ x ] I have added tests that prove my fix is effective or that my feature works
  • [ x ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Screenshots

Data coming in from all the regions

Screenshot 2024-11-08 at 4 11 03 PM

The config of GCP for aiplatform service with region enabled as us-east4

Screenshot 2024-11-08 at 4 07 36 PM

Data coming in after region filter is applied

Screenshot 2024-11-08 at 4 10 50 PM

Config with regions enabled

Screenshot 2024-11-08 at 4 38 19 PM

Data after the above Regions Filter

Screenshot 2024-11-08 at 4 31 16 PM

@ishleenk17 ishleenk17 self-assigned this Nov 7, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 7, 2024
@botelastic
Copy link

botelastic bot commented Nov 7, 2024

This pull request doesn't have a Team:<team> label.

Copy link
Contributor

mergify bot commented Nov 7, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ishleenk17? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Nov 7, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 7, 2024
@ishleenk17 ishleenk17 marked this pull request as ready for review November 7, 2024 15:50
@ishleenk17 ishleenk17 requested review from a team as code owners November 7, 2024 15:50
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ishleenk17 ishleenk17 merged commit 8cd6feb into elastic:main Nov 8, 2024
22 checks passed
mergify bot pushed a commit that referenced this pull request Nov 8, 2024
* Add support for Vertex AI service in GCP module

* update changelog

(cherry picked from commit 8cd6feb)
ishleenk17 added a commit that referenced this pull request Nov 27, 2024
…) (#41564)

* Add support for Vertex AI service in GCP module

* update changelog

(cherry picked from commit 8cd6feb)

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
@ishleenk17 ishleenk17 added the backport-8.16 Automated backport with mergify label Nov 27, 2024
mergify bot pushed a commit that referenced this pull request Nov 27, 2024
* Add support for Vertex AI service in GCP module

* update changelog

(cherry picked from commit 8cd6feb)
@ishleenk17 ishleenk17 added the backport-8.17 Automated backport with mergify label Nov 27, 2024
mergify bot pushed a commit that referenced this pull request Nov 27, 2024
* Add support for Vertex AI service in GCP module

* update changelog

(cherry picked from commit 8cd6feb)
ishleenk17 added a commit that referenced this pull request Nov 28, 2024
…) (#41806)

* Add support for Vertex AI service in GCP module

* update changelog

(cherry picked from commit 8cd6feb)

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
ishleenk17 added a commit that referenced this pull request Dec 2, 2024
…) (#41807)

* Add support for Vertex AI service in GCP module

* update changelog

(cherry picked from commit 8cd6feb)

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify enhancement needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GCP region for Vertex AI
3 participants