Move handling of json fields to harvester #4159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of historical reasons, the common.MapStr event was generated in `input.Event` which required the JSONConfig to be passed to the Event object. This is not nice because it is harvester specific knowledge in the event object which should not be the case. With the introduction of the data object is is now possible that the arranging of the json fields already happens in the harvester. The @timestamp field had to be moved to the harvester to make sure json error handling still works as before. Unused Event fields were removed. Further generalisation of the event handling will be introduce with the addition of new prospector types.
7AC
approved these changes
May 1, 2017
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of historical reasons, the common.MapStr event was generated in
input.Eventwhich required the JSONConfig to be passed to the Event object. This is not nice because it is harvester specific knowledge in the event object which should not be the case. With the introduction of the data object is is now possible that the arranging of the json fields already happens in the harvester.Further generalisation of the event handling will be introduce with the addition of new prospector types.