Unify event, data and state handling in filebeat #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
Filebeat
|
jenkins, retest it |
The data and event handling has grown over time in filebeat. One the one hand meta data and event data was mixed and different structure to handle the data existed. The structures which existed were focused in the log prospector. This change brings a unified data handling with a data object which separates event, meta data and state. This new model should allow to add new prospector types and use the same data objects. The reason it ended up in `util` package is because `data` is taken by the data folder and `common` would lead to too many conflicts with `common` package in libbeat.
| @@ -42,7 +42,7 @@ func (o *Outlet) SetSignal(signal <-chan struct{}) { | |||
| o.signal = signal | |||
| } | |||
|
|
|||
| func (o *Outlet) OnEvent(event *input.Data) bool { | |||
| func (o *Outlet) OnEvent(data *util.Data) bool { | |||
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported method Outlet.OnEvent should have comment or be unexported
| "github.com/elastic/beats/libbeat/common" | ||
| ) | ||
|
|
||
| type Data struct { |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported type Data should have comment or be unexported
| Meta Meta | ||
| } | ||
|
|
||
| type Meta struct { |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported type Meta should have comment or be unexported
| Module string | ||
| } | ||
|
|
||
| func NewData() *Data { |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported function NewData should have comment or be unexported
7AC
approved these changes
May 2, 2017
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data and event handling has grown over time in filebeat. One the one hand meta data and event data was mixed and different structure to handle the data existed. The structures which existed were focused in the log prospector. This change brings a unified data handling with a data object which separates event, meta data and state. This new model should allow to add new prospector types and use the same data objects.
The reason it ended up in
utilpackage is becausedatais taken by the data folder andcommonwould lead to too many conflicts withcommonpackage in libbeat.