[xpack][metricbeats][gcp] don't skip first value in histogram calculations #41822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
|
mergify
bot
added
the
backport-8.x
gpop63
added
the
Team:Obs-InfraObs
botelastic
bot
removed
the
needs_team
gpop63
added
Team:obs-ds-hosted-services
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
botelastic
bot
removed
the
needs_team
gpop63
approved these changes
Dec 2, 2024
|
@stefans-elastic : Thanks for the change. |
ishleenk17
reviewed
Dec 2, 2024
good point, thanks |
ishleenk17
approved these changes
Dec 3, 2024
|
@elastic/obs-ds-hosted-services could you take a look at this PR? |
kaiyan-sheng
approved these changes
Dec 3, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
…tions (#41822) * [xpack][metricbeats][gcp] don't skip first value in histogram calculations * update changelog * update PR id in changelog * update data_topic.json * update data_topic.json * fix integer overflow --------- Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com> (cherry picked from commit a1acad5)
6 tasks
stefans-elastic
added a commit
that referenced
this pull request
Dec 23, 2024
…tions (#41822) (#41870) * [xpack][metricbeats][gcp] don't skip first value in histogram calculations * update changelog * update PR id in changelog * update data_topic.json * update data_topic.json * fix integer overflow --------- Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com> (cherry picked from commit a1acad5) Co-authored-by: stefans-elastic <stefan.stas@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Don't skip first value in histogram upper bound calculations.
This should be done because according to GCP doc (https://cloud.google.com/monitoring/api/ref_v3/rpc/google.api) the histogram (Exponential and Linear) upper bound should include bucket values at index 0.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Closes #
Use cases
Screenshots
Here is screenshot from local test -
valuesseem to be okLogs