Add type to state info #4185
Merged
Add type to state info #4185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of new prospector types each prospector can have different state information. To differentiate between the different states for the prospector the `type` was added to each registry state.
tsg
reviewed
May 3, 2017
| Timestamp time.Time `json:"timestamp"` | ||
| TTL time.Duration `json:"ttl"` | ||
| Type string `json:"type"` |
There was a problem hiding this comment.
Name it "input_type" to differentiate it from the "document_type"?
There was a problem hiding this comment.
I'm hoping to have only one type in the future. More accurate here would be ProspectorType but as I try to keep the state as "independent" as possible with potentially have it in libbeat one day, I would just call it Type.
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of new prospector types each prospector can have different state information. To differentiate between the different states for the prospector the
typewas added to each registry state.