Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for RFC7231 methods to http monitors #41975

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Add support for RFC7231 methods to http monitors #41975

merged 2 commits into from
Dec 19, 2024

Conversation

emilioalvap
Copy link
Collaborator

@emilioalvap emilioalvap commented Dec 10, 2024 •
edited
Loading

Proposed commit message

Add support for RFC7231 methods to http monitors.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  1. Compile heartbeat locally.
  2. Create http monitors with additional supported methods:
  • PUT
  • DELETE
  • CONNECT
  • TRACE
  1. Execute and check expected results.

Related issues

@emilioalvap emilioalvap added enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team backport-skip Skip notification from the automated backport with mergify labels Dec 10, 2024
@emilioalvap emilioalvap requested a review from a team as a code owner December 10, 2024 16:18
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 10, 2024
tetianakravchenko
tetianakravchenko approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@tetianakravchenko tetianakravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vigneshshanmugam
vigneshshanmugam approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilioalvap emilioalvap enabled auto-merge (squash) December 19, 2024 15:43
@emilioalvap emilioalvap merged commit 59bfb15 into elastic:main Dec 19, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetianakravchenko tetianakravchenko tetianakravchenko approved these changes

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees

@emilioalvap emilioalvap

Labels
backport-skip Skip notification from the automated backport with mergify enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support PUT for check.request.method in heartbeat http check
4 participants
@emilioalvap @elasticmachine @vigneshshanmugam @tetianakravchenko